Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Throw Name Customization Option #69

Open
sirkerry opened this issue May 26, 2024 · 9 comments · May be fixed by #77
Open

Saving Throw Name Customization Option #69

sirkerry opened this issue May 26, 2024 · 9 comments · May be fixed by #77
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sirkerry
Copy link

It would be really nice to have an option to change/customize the names of the various Saving Throws.

@orffen
Copy link
Owner

orffen commented Jun 1, 2024

I like this, I have been thinking about configuration options for some time. Will definitely plan to develop this.

@orffen orffen added the enhancement New feature or request label Jun 1, 2024
@orffen orffen added this to the rX milestone Jun 1, 2024
@DC23
Copy link
Collaborator

DC23 commented Nov 4, 2024

I've recently spent a bunch of time learning how to implement system and module settings with breakout forms if needed. Happy to help implement this, but not for r14. Gotta stay on target for v12 :)

@orffen
Copy link
Owner

orffen commented Nov 4, 2024

Absolutely - I've been wanting to add config options for a while.

Maybe the default damage bonus we were chatting about in Discord could be handled this way as well - on by default but the option to remove it in config?

@DC23
Copy link
Collaborator

DC23 commented Nov 4, 2024

Sounds good. Also, I still need to learn how to do this with the new V2 application API. I've used the V2 API in macros for dialogs, but not anywhere more serious like a module or system settings. But for future proofing, I'd not want to implement here in something I know is deprecated in Foundry v14

@DC23
Copy link
Collaborator

DC23 commented Nov 18, 2024

To clarify, is this request only to allow customisation of the current saving throw names? I know some supplements change the number of saving throws and their derivation formula/progress - for example Saving Throw Options gives a D&D3e 3 save alternative as well as a single saving throw alternative. Before I start implementing anything, I want to be doubly clear that all we are talking about here is the ability to change the names given to the current saves, not the number of those saves.

That said, once that's done, reducing the number of saves displayed probably wouldn't be too much of a stretch goal.

@DC23
Copy link
Collaborator

DC23 commented Nov 18, 2024

These would be GM-only settings, to ensure consistency within a game world.

@sirkerry
Copy link
Author

To clarify, is this request only to allow customisation of the current saving throw names?

My request was just to be able to change the names of the various saves, not change the quantity of them, although that would be a nice feature to have for some GMs.

@DC23
Copy link
Collaborator

DC23 commented Nov 23, 2024

I think I'll implement this as incremental features. They may not be released at the same time.

  1. customisable save names
  2. customisable number of saves

DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 23, 2024
@DC23
Copy link
Collaborator

DC23 commented Nov 23, 2024

Screenshot 2024-11-23 160721
Not connected to the character sheets or other templates (such as chat messages yet) since that's actually a fair bit of work, but it's progress.

DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 26, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 26, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 26, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
Formatted saves-settings with new prettier config
orffen#69
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
fixed required attribute bug for when it is passed into the template as false (it was correct for values of true).
orffen#69
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
DC23 added a commit to DC23/basicfantasyrpg that referenced this issue Nov 27, 2024
@DC23 DC23 self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants