Virtual Coffee
#317 PR help #390
-
|
Good morning, I worked on issue #317 and my PR is allowing me to merge my changes without a review. I'm wondering if that means I made my PR incorrectly. I forked the repo, made my changes locally,created a PR and linked the issue number. Was that the incorrect way of doing it? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Hey Ebony! The problem here is the base branch in your Pull Request. It is set you main on your fork, but what it needs to be to get back to the site is main on Virtual Coffee's version. You should be able to change this by hitting edit next to the PR title and then choosing the correct base from the drop downs - something like Virtual-Coffee/virtualcoffee.io/main |
Beta Was this translation helpful? Give feedback.
-
|
Okay thank you, I'll follow that now. |
Beta Was this translation helpful? Give feedback.
-
|
It wasn't giving me the correct base as an option. So I merged it into my repo and then it said I was behind the original repo. So I created a new PR there. So in short it should be correct now lol. 🤞🏾 |
Beta Was this translation helpful? Give feedback.
Hey Ebony!
The problem here is the base branch in your Pull Request. It is set you main on your fork, but what it needs to be to get back to the site is main on Virtual Coffee's version. You should be able to change this by hitting edit next to the PR title and then choosing the correct base from the drop downs - something like Virtual-Coffee/virtualcoffee.io/main