Logger has been moved and implemented as an internal lib #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
origranot
reviewed
Sep 19, 2023
| @@ -97,3 +97,4 @@ describe('ShortenerController', () => { | |||
| }); | |||
| }); | |||
| }); | |||
| import { reduce } from 'rxjs'; | |||
There was a problem hiding this comment.
I added it by mistake
origranot
requested changes
Sep 19, 2023
There was a problem hiding this comment.
@senderh55 This looks great!
There is a small comment I added (I guess this line was added by mistake)
Also, please run lint and test in your own env to make sure the CI works.
|
Thanks for your feedback. I updated the path in .eslintrc and project.json in the logger for the lint and fixed the mistake in shortener.controller.spec. |
|
@senderh55 Great job! I had to remove the buildable option from the logger. Closes #445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #445