Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orion:pages feature support named content spaces in dynamic layouts #413

Open
sean-stanley opened this issue May 12, 2016 · 0 comments
Open

Comments

@sean-stanley
Copy link
Contributor

When setting up a page template with orion.pages.addTemplate it would be nice to copy the AccountsTemplates.configure api options to include something like defaultLayoutRegions: Object
that will simply append the object to the layout's data context. This way a more complex dynamic layout using more than just "yield" can be used for setting up pages.

In my particular instance some pages have different navbars and footers. Rather than have two layouts I use {{<Template.dynamic nav=nav}} to determine which navbar to return.

Currently pages generated with orion:pages will have no value for nav and thus will not render any template in this zone.

A not-great workaround is using if/else to assign a default navbar or footer.

I can write a pull request for this at some point if interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant