Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the util build system based on suggestions in #4308 #4333

Open
anagainaru opened this issue Aug 31, 2024 · 1 comment
Open

Update the util build system based on suggestions in #4308 #4333

anagainaru opened this issue Aug 31, 2024 · 1 comment

Comments

@anagainaru
Copy link
Contributor

Based on the discussion in #4308 the build system for the utility scripts in source/util needs a few updates.

  1. Use CMAKE_CURRENT_BINARY_DIR instead of PROJECT_BINARY_DIR
  2. Add quotes for all paths
  3. Use the maybe_xyz convention in all cases when something might be generated or not
  4. Use using syntax=yaml to highlight the syntact in the generated cmake files for bpcmp and bpls

@vicentebolea, did I forget anything?
@vicentebolea
Copy link
Collaborator

No, it looks good! Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vicentebolea @anagainaru