Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instanceOfErrorBrowserLocationChangeRequired problem #383

Open
4 of 5 tasks
dankobg opened this issue Nov 6, 2024 · 0 comments
Open
4 of 5 tasks

instanceOfErrorBrowserLocationChangeRequired problem #383

dankobg opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something is not working.

Comments

@dankobg
Copy link

dankobg commented Nov 6, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

export function instanceOfErrorBrowserLocationChangeRequired(value: object): value is ErrorBrowserLocationChangeRequired {
    return true;
}

Why is it just true? shouldn't it check obj properties?
This is typescript client fetch

Reproducing the bug

This happens when handling errors when you need to re login in after session_refresh_required.
It always returns true so it is useless

Relevant log output

No response

Relevant configuration

No response

Version

1.3

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker Compose

Additional Context

No response

@dankobg dankobg added the bug Something is not working. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant