Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Ruby OpenAPI Generator version #327

Merged

Conversation

jmlind
Copy link
Contributor

@jmlind jmlind commented Feb 13, 2024

This simply bumps the OpenAPI Generator version from v6.0.1 to v7.3.0

Related Issue or Design Document

This resolves an issue logged on the client-ruby repo. Summary:

Requests are still sent to the playground when base_url is set in OryClient.configure, and this was identified as an issue with the OpenAPI Generator which was fixed in v6.6.0. Thanks to @germs12 for the in-depth comment on that issue. ory/client-ruby#1 (comment)

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jmlind jmlind marked this pull request as draft February 13, 2024 21:17
@jmlind jmlind changed the title chore: Update Ruby OpenAPI Generator version chore: update Ruby OpenAPI Generator version Feb 13, 2024
@jmlind jmlind marked this pull request as ready for review February 13, 2024 21:18
@jmlind jmlind force-pushed the chore/update-ruby-openapi-generator-version branch from 5530707 to b0da71c Compare February 13, 2024 21:57
@jmlind jmlind force-pushed the chore/update-ruby-openapi-generator-version branch from b0da71c to c9c653f Compare February 13, 2024 21:58
@vinckr vinckr requested a review from aeneasr February 23, 2024 10:48
@aeneasr aeneasr merged commit 70e7d67 into ory:master Feb 23, 2024
1 check passed
@jmlind jmlind deleted the chore/update-ruby-openapi-generator-version branch February 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants