Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openqa-revtui] -c parameter should support multiple files #114

Open
asmorodskyi opened this issue Jul 6, 2023 · 2 comments
Open

[openqa-revtui] -c parameter should support multiple files #114

asmorodskyi opened this issue Jul 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@asmorodskyi
Copy link
Member

./openqa-revtui -c ./_review/*.toml - suppose to consume ALL toml files in this folder

currently it is not happening

@grisu48 grisu48 changed the title openqa-revtui -c parameter should support regex openqa-revtui -c parameter should support multiple files Jul 6, 2023
@grisu48 grisu48 changed the title openqa-revtui -c parameter should support multiple files [openqa-revtui] -c parameter should support multiple files Jul 6, 2023
@grisu48 grisu48 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 6, 2023
@grisu48
Copy link
Collaborator

grisu48 commented Jul 6, 2023

The issue is that openqa-revtui currently does not support multiple input files but only one. I consider this as a feature request and need to check if that's even possible to do.

Currently only the latest toml configuration file is considered, we should try to improve this.

@grisu48
Copy link
Collaborator

grisu48 commented Jul 6, 2023

Based on the current commit 93d1ab7:

  • We have a singleton Config class which holds all configuration parameters
  • This class only allows one instance URL
  • We could add more job groups there (added by each file) but that would still not allow multiple different instances

We would likely to contain all relevant attributes in a new datastructure and create a slice of them in the Config class. I'm leaving this here for now, as this requires further investigation if the feature is feasible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants