Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning and migration support for settings #52

Open
3 tasks
andersevenrud opened this issue Jan 20, 2019 · 0 comments · May be fixed by #76
Open
3 tasks

Add versioning and migration support for settings #52

andersevenrud opened this issue Jan 20, 2019 · 0 comments · May be fixed by #76
Assignees
@andersevenrud
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed implemented Has been implemented, but not necessarily finished

Comments

@andersevenrud
Copy link
Member

andersevenrud commented Jan 20, 2019 •
edited
Loading

Currently when you change the settings in src/client/index.js of the distro, these will not be transitioned because users might have local settings stored.

By adding support for a revision number these settings could be reset automatically easily (simply load core settings on login instead of the user ones).

Also, adding support for custom migration scripts would be pretty neat so no custom settings would be lost.

  • Add revision config option
  • Implement revision override
  • Add migration script API

Ref: #76
@andersevenrud andersevenrud added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 20, 2019
@andersevenrud andersevenrud self-assigned this Jan 20, 2019
andersevenrud added a commit that referenced this issue Oct 12, 2019
@andersevenrud
Added support for resetting settings via revision number (#52)
0a5c1e2 
This is the first step in adding migrations. This commit adds the
support for resetting the user settings when you change the
"__revision__" value of a settings namespace.
andersevenrud added a commit that referenced this issue Oct 12, 2019
@andersevenrud
Added support for resetting settings via revision number (#52)
e37aa2e 
This is the first step in adding migrations. This commit adds the
support for resetting the user settings when you change the
"__revision__" value of a settings namespace.
andersevenrud added a commit that referenced this issue Oct 12, 2019
@andersevenrud
Added support for resetting settings via revision number (#52)
a70d96c 
This is the first step in adding migrations. This commit adds the
support for resetting the user settings when you change the
"__revision__" value of a settings namespace.
@andersevenrud andersevenrud added the implemented Has been implemented, but not necessarily finished label Oct 12, 2019
@andersevenrud andersevenrud linked a pull request Apr 14, 2020 that will close this issue
Added support for resetting settings via revision number (#52) #76
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andersevenrud andersevenrud

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed implemented Has been implemented, but not necessarily finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for resetting settings via revision number (#52) os-js/osjs-client
1 participant
@andersevenrud