nvme: delete all namespaces in _remove_nvmet_subsystem()

A subsystem might have more than one namespace, so delete all of them in
_remove_nvmet_subsystem().

This change was to be made before the commit 67e25d7 ("nvme/052: do
not create namespace when setting up the target"), which assumes that
_remove_nvmet_subsystem() delets all namespaces. However, commit order
was modified then the test case nvme/052 now fails without this commit.

Signed-off-by: Hannes Reinecke <[email protected]>
[Shin'ichiro: resolved conflicts]
Fixes: 67e25d7 ("nvme/052: do not create namespace when setting up the target")
Reviewed-by: Daniel Wagner <[email protected]>
Tested-by: Yi Zhang <[email protected]>
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>

common/nvme

@@ -640,7 +640,10 @@ _remove_nvmet_subsystem() {
 	local nvmet_subsystem="$1"
 	local subsys_path="${NVMET_CFS}/subsystems/${nvmet_subsystem}"
 
-	_remove_nvmet_ns "${nvmet_subsystem}" "${def_nsid}"
+	for n in "${subsys_path}/namespaces/"*; do
+		[ -d "${n}" ] || continue
+		_remove_nvmet_ns "${nvmet_subsystem}" "${n##*/}"
+	done
 	rm -f "${subsys_path}"/allowed_hosts/*
 	rmdir "${subsys_path}"
 }

tests/nvme/016

@@ -47,11 +47,6 @@ test() {
 	_remove_nvmet_subsystem_from_port "${port}" "${def_subsysnqn}"
 	_remove_nvmet_port "${port}"
 
-	for ((i = iterations; i > 1; i--)); do
-		nsid=$((def_nsid + i - 1))
-		_remove_nvmet_ns "${def_subsysnqn}" "${nsid}"
-	done
-
 	_remove_nvmet_subsystem "${def_subsysnqn}"
 
 	echo "Test complete"

tests/nvme/017

@@ -47,11 +47,6 @@ test() {
 	_remove_nvmet_subsystem_from_port "${port}" "${def_subsysnqn}"
 	_remove_nvmet_port "${port}"
 
-	for ((i = iterations; i > 1; i--)); do
-		nsid=$((def_nsid + i - 1))
-		_remove_nvmet_ns "${def_subsysnqn}" "${nsid}"
-	done
-
 	_remove_nvmet_subsystem "${def_subsysnqn}"
 
 	rm "$(_nvme_def_file_path)"