The deeply nested list structure used for defining role mappings is highly complex and can be difficult to maintain. Consider refactoring this into a more manageable format, such as using a flat structure with explicit dependencies or utilizing a class-based approach to define roles and dependencies. This would enhance readability, make the codebase easier to maintain, and reduce the risk of errors during modifications.

[berendt]

          The deeply nested list structure used for defining role mappings is highly complex and can be difficult to maintain. Consider refactoring this into a more manageable format, such as using a flat structure with explicit dependencies or utilizing a class-based approach to define roles and dependencies. This would enhance readability, make the codebase easier to maintain, and reduce the risk of errors during modifications.

Suggested Refactoring:

# Example of a possible refactoring using a class-based approach

class Role:
    def __init__(self, name, dependencies=None):
        self.name = name
        self.dependencies = dependencies or []

# Define roles
roles = [
    Role('neutron', dependencies=[
        Role('wait-for-nova', dependencies=[
            Role('octavia')
        ])
    ]),
    Role('barbican'),
    Role('designate'),
    Role('ironic')
]

Originally posted by @codereviewbot-ai[bot] in #1101 (comment)