-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servers migrated to Jakarta #198
Conversation
01958a8
to
8c148c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, need corresponding -P change to the CI workflows and that's about it.
<profile> | ||
<!-- some servlet containers (Tomcat) does not ship with a JSTL impl | ||
In such cases, run with this profile--> | ||
<id>with-jstl-impl</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update GH Action workflows to use this profile when testing with tomcat.
I think it's ready to merge. Do you think you could please resolve merge conflicts? |
…l.git into jakarta_generated
@berezovskyi I can try. But there is still 1 change request still pending on your side? |
and, did you see my latest changes to the readme file? |
@berezovskyi ! We should first merge Lyo, before we merge this PR. Ready to go there? |
yes, looks good
ah, forgot that. btw, only RM was "tomcatified", we need 3 more docker files and to update the compose yaml. |
Sorry! Don't get what you are after here. |
I think the build will succeed only once Jenkins pushes new SNAPSHOTS to eclipse repos. |
I can take a look at that. |
I can then leave it to you to merge the PR also then? |
I think your check will be needed on |
THat was the conflict I had in the other pom.xml files. For some reason, a merge has also changed the Lyo version to Alpha. |
All 4 refImpl servers generated based on the latest LyoDesigner (currently under PR eclipse-lyo/lyo.designer#276) to support migration to Jakarta.