Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers migrated to Jakarta #198

Merged
merged 23 commits into from
Apr 5, 2024
Merged

Servers migrated to Jakarta #198

merged 23 commits into from
Apr 5, 2024

Conversation

jadelkhoury
Copy link
Member

All 4 refImpl servers generated based on the latest LyoDesigner (currently under PR eclipse-lyo/lyo.designer#276) to support migration to Jakarta.

src/server-rm/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@berezovskyi berezovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need corresponding -P change to the CI workflows and that's about it.

<profile>
<!-- some servlet containers (Tomcat) does not ship with a JSTL impl
In such cases, run with this profile-->
<id>with-jstl-impl</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update GH Action workflows to use this profile when testing with tomcat.

@berezovskyi
Copy link
Member

@berezovskyi berezovskyi marked this pull request as ready for review March 31, 2024 15:42
@berezovskyi
Copy link
Member

I think it's ready to merge. Do you think you could please resolve merge conflicts?

@Jad-el-khoury
Copy link
Contributor

@berezovskyi I can try. But there is still 1 change request still pending on your side?

@jadelkhoury
Copy link
Member Author

and, did you see my latest changes to the readme file?

@Jad-el-khoury
Copy link
Contributor

@berezovskyi ! We should first merge Lyo, before we merge this PR. Ready to go there?

@berezovskyi
Copy link
Member

and, did you see my latest changes to the readme file?

yes, looks good

But there is still 1 change request still pending on your side?

ah, forgot that. btw, only RM was "tomcatified", we need 3 more docker files and to update the compose yaml.

@jadelkhoury
Copy link
Member Author

ah, forgot that. btw, only RM was "tomcatified", we need 3 more docker files and to update the compose yaml.

Sorry! Don't get what you are after here.

@berezovskyi
Copy link
Member

I think the build will succeed only once Jenkins pushes new SNAPSHOTS to eclipse repos.

@berezovskyi
Copy link
Member

Sorry! Don't get what you are after here.

I can take a look at that.

@jadelkhoury
Copy link
Member Author

I can then leave it to you to merge the PR also then?

@berezovskyi
Copy link
Member

I can then leave it to you to merge the PR also then?

I think your check will be needed on src/lib-common/pom.xml, it was referencing 6.0.0.Alpha1. Also the kotlin client is broken.

@Jad-el-khoury
Copy link
Contributor

THat was the conflict I had in the other pom.xml files. For some reason, a merge has also changed the Lyo version to Alpha.
src/lib-common/pom.xml looks good.

@berezovskyi berezovskyi merged commit 3ca27c7 into master Apr 5, 2024
13 checks passed
@berezovskyi berezovskyi deleted the jakarta_generated branch April 5, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants