Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple PDR peaks doesn't work #2

Open
vetlewi opened this issue Nov 2, 2022 · 3 comments
Open

Multiple PDR peaks doesn't work #2

vetlewi opened this issue Nov 2, 2022 · 3 comments

Comments

@vetlewi
Copy link
Collaborator

vetlewi commented Nov 2, 2022

In the documentation, TALYS supports up to two PDR peaks. However, TALYS will only use the first peak.

vetlewi added a commit that referenced this issue Nov 2, 2022
This forces talys to calculate the PDR strength with resonance parameter 1 and 2. Addresses issue #2
@cecgresonant
Copy link

That's a bad bug.. Did you write to the Stephane's about it?

@vetlewi
Copy link
Collaborator Author

vetlewi commented Nov 3, 2022

That's a bad bug.. Did you write to the Stephane's about it?

No, not yet. But I have a fix, see 1ec60de

In addition, I'd like to add a change in the code where TALYS writes the output file to ensure that all PDR parameters are properly written. This will require:

  • Add a new global variable similar to the ngr but for PDR
  • Modify gammapar.f to count the number of PDRs for each multipolarity (similar to how it handles ngr)
  • Modify gammaout.f to write PDR parameters to the output
  • Modify partable.f to include the PDR parameters in the model parameters written to file

@vetlewi
Copy link
Collaborator Author

vetlewi commented Nov 3, 2022

To be clear, the issue is as following. If you add two E1 PDR to the strength function of a given nucleus, say 145Nd you'd write in the input to TALYS

epr 60 145 7.5 E1 1
spr 60 145 1.5 E1 1
gpr 60 145 0.9 E1 1

epr 60 145 9.5 E1 2
spr 60 145 12.2 E1 2
gpr 60 145 1.2 E1 2

And you'd expect there to be two standard Lorentzians added to the E1 strength with the given parameters. However, TALYS only uses the first set of parameters (the ones marked with 1), thus only one extra Lorentzian is added to the E1 strength.

This is contrary to the documentation (user manual).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants