-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunny advices not to use this. Are these not properly supported? #39
Comments
following |
Our plan is to move away from bindings and use osmois-std instead. The reason is that with osmosis-std uses stargate msgs and stargate queries so that every protobuf services are avaiiable out of the box, the library just provide convenient stargate msg construction. No additional chain code needed for any new bindings. For queries, they are only available as whitelisted ones here to avoid non-determinism. |
Does this mean bindings won't work in the future? Or just that they won't be expanded? Because currently bindings allow better functionality for mints and burns but I can't use both (bindings & std) in a single contract due to the typed Response. |
@triccs it won't be expanded, but could you elaborate on 2 points:
since I'm maintaining
I think for this point it should not be a problem, could you provide specific example so that I can see if I can help with the issue? |
@iboss-ptk Mints don't allow you to specify a
|
For the first point, it does allow denom choice, since let msg_mint = MsgMint {
sender: "<sender_addr>"
// the `super::super::super::cosmos::base::v1beta1::Coin` type has `impl From<cosmwasm_std::Coin>`
amount: Some(cosmwasm_std::Coin::new(1_000, "factory/<creator_addr>/<subdenom>").into())
} For second point, it's actually possible as is but a bit convoluted, this commit should fix it but you can also roll your own. I will get this published soon. Using the main branch will do the trick as well. |
My fault on the first question, that's so simple thank you. Re: 2nd. Perfect, I'll end up testing this as we expand the proxy contract. |
@sunnya97 Should these bindings be used at all?
The text was updated successfully, but these errors were encountered: