V8 Hard Fork Testing #1485
Replies: 2 comments 1 reply
-
Further issues upon letting the testnet run for ~1 hour
|
Beta Was this translation helpful? Give feedback.
-
Unpool Testings / Edgecases V3ConcernsLow Priority#3: Validators still need to be aware that the upgrade will happen instantly. It had previously took me a while to figure out that my node was actually upgraded because the few logs there are happen in ms and then get burried in KVstore logs. Setup
Pre-Upgrade
Upgrade
Post-Upgrade
Case 1: lock that is not superfluid delegated, not unlocking: 1338466
Case 2: lock that is not superfluid delegated, unlocking: 1338463
Case 3: lock that is superfluid delegated, not unlocking: 1338461
Case 4: lock that is superfluid undelegating, not unlocking: 1338464
Case 5: lock that is superfluid unbonding, unlocking: 1338465
Pool Incentives
|
Beta Was this translation helpful? Give feedback.
-
Unpool Testings / Edgecases V2
Concerns
High Priority
I dont understand what happens in Case 3. After I run the unpool command, the superfluid stake that existed prior to the unpool command no longer shows in superfluid delegations (as expected), but does NOT show as undelegating under superfluid undelegations like the others do. Further information below in Case 3.Dev explained this is intentional behavior in order to implement this change safely.Medium Priority
The more separate locks that need to get created (i.e. accounts with locks in multiple durations), the more gas that the tx requires. An unpool tx that only needed four locks created required --gas 5000000 --fees 1000000uosmo. It might be better to specify lock-id instead of combining them into one large message to prevent stuck txs.
Low Priority
Validators need to be aware that the upgrade will happen instantly. It took me a while to figure out that my node was actually upgraded because the few logs there are happen in ms and then get burried in KVstore logs.
Setup
Pre-Upgrade
Create varying 2 hr lockup / superfluid delegations
Create nodes synced to testnet, each having different fork heights
Edit new binary on all VMs to have required fork heights above
Run commands to get 2hr locks that need to start unlocking to unlock according to respective cases above
osmosisd tx lockup begin-unlock-by-id 1338463 --chain-id osmo-hardfork-test -b block --from val4
B0EC5D879B9ADA5592516ED06F2CEBF6B5CEB9C130370633DD4D598CE123B710
osmosisd tx superfluid undelegate 1338464 --chain-id osmo-hardfork-test -b block --from val5 --gas 450000
BD9E91EB4610E6FE25975542C442F91081CC1E04094E0B225B505201D5988D24
osmosisd tx superfluid undelegate 1338465 --chain-id osmo-hardfork-test -b block --from val6 --gas 450000
BE98473D52074F9208FE331B07E05952C04DB6A672FEBC32AB2CB2F76C82A07E
osmosisd tx superfluid unbond-lock 1338465 --chain-id osmo-hardfork-test -b block --from val6
9A2BE04BDA8DD54F65B58F46BD4E0162B87E8E18E031F6E9D3380618926A2FD6
Upgrade
Run new binary on all nodes
Once fork height happens, ensure nodes with diff fork heights no longer sync
Val: 4391031: Pass
Node1: 4391031: Pass
NodePre: 4390910: Failed as expected
NodePost: 4391041: Failed as expected
Post-Upgrade
osmosisd tx superfluid unpool-whitelisted-pool 560 --chain-id osmo-hardfork-test -b block --from val7 --gas 700000
38051706F0316AC53589537EADADC395F018C60F1A499AB7E0E30C5576CD6B0F
osmosisd tx superfluid unpool-whitelisted-pool 562 --chain-id osmo-hardfork-test -b block --from val4 --gas 700000
F7C137D9948A2C1E0FBAE168632246E1061D01D68C1AD4B49A46A8AFB33BC4CA
osmosisd tx superfluid unpool-whitelisted-pool 560 --chain-id osmo-hardfork-test -b block --from val4 --gas 5000000 --fees 1000000uosmo
D3A03883A2224DA792DA13FDAF02BD361878FB574B47A046EA29C98ED89A4C1C
osmosisd tx superfluid unpool-whitelisted-pool 560 --chain-id osmo-hardfork-test -b block --from val5 --gas 1000000
292DB19B7FF535BB8795D472AFD73B4E13A8905684A2FAA74638E23DD253CF4A
osmosisd tx superfluid unpool-whitelisted-pool 560 --chain-id osmo-hardfork-test -b block --from val6 --gas 500000
353F9BE1681C20D68057910F8B198499C4DAE8E95C31D59648B99B1124DE3A00
Case 1: lock that is not superfluid delegated, not unlocking: 1338466
Unpooling locks creates a new lock consisted of assets from
ExitPool
: PASSLiquidity has been successfully removed from the pool (560): PASS
osmosisd q gamm pool 560 --height 4391091
osmosisd q gamm pool 560 --height 4391093
Case 2: lock that is not superfluid delegated, unlocking: 1338463
Unpooling locks creates a new lock consisted of assets from
ExitPool
: PASSLiquidity has been successfully removed from the pool (562): PASS
osmosisd q gamm pool 562 --height 4391106
osmosisd q gamm pool 562 --height 4391108
If the lock was unbonding, the remaining unbonding time is preserved after unpooling: PASS
osmosisd q lockup lock-by-id 1338469
osmosisd q lockup lock-by-id 1338470
Case 3: lock that is superfluid delegated, not unlocking: 1338461
Unpooling locks creates a new lock consisted of assets from
ExitPool
: PASSLiquidity has been successfully removed from the pool: PASS
osmosisd q gamm pool 560 --height 4391341
osmosisd q gamm pool 560 --height 4391343
If the lock was superfluid staked, undelegation has been properly done after unpooling: FAIL?
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1dukzat7jx2q5cl6vp7d2rnvrzw8tphplwr2s4s --height 4391341
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1dukzat7jx2q5cl6vp7d2rnvrzw8tphplwr2s4s --height 4391343
osmosisd q superfluid superfluid-delegation-by-delegator osmo1dukzat7jx2q5cl6vp7d2rnvrzw8tphplwr2s4s --height 4391341
osmosisd q superfluid superfluid-delegation-by-delegator osmo1dukzat7jx2q5cl6vp7d2rnvrzw8tphplwr2s4s --height 4391343
Case 4: lock that is superfluid undelegating, not unlocking: 1338464
ExitPool
: PASSosmosisd q gamm pool 560 --height 4391130
osmosisd q gamm pool 560 --height 4391132
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1ffrdaaa6lwcmd95k0v62rlxhvhuy5f5v6gx4gu --height 4390757
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1ffrdaaa6lwcmd95k0v62rlxhvhuy5f5v6gx4gu --height 4390758
Case 5: lock that is superfluid unbonding, unlocking: 1338465
Unpooling locks creates a new lock consisted of assets from
ExitPool
: PASSLiquidity has been successfully removed from the pool (560): PASS
osmosisd q gamm pool 560 --height 4391135
osmosisd q gamm pool 560 --height 4391137
If the lock was unbonding, the remaining unbonding time is preserved after unpooling: PASS
osmosisd q lockup lock-by-id 1338473
osmosisd q lockup lock-by-id 1338474
If the lock was superfluid staked, undelegation has been properly done after unpooling: PASS
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1667565vxg0g40v8rwcqp3nrl3l0zs2ln363pke --height 4390761
osmosisd q superfluid superfluid-undelegation-by-delegator osmo1667565vxg0g40v8rwcqp3nrl3l0zs2ln363pke --height 4390762
Pool Incentives
Wallets Used
val4
osmo1dukzat7jx2q5cl6vp7d2rnvrzw8tphplwr2s4s
grid olive emotion actor urban universe behave audit bracket bonus shy drop ribbon verb private crush comic nose produce inflict crane during shy quick
val5
osmo1ffrdaaa6lwcmd95k0v62rlxhvhuy5f5v6gx4gu
slow pool iron drip relax rural huge trial agree hurry window task quote measure snow general mystery agent loyal skull lady affair disagree cube
val6
osmo1667565vxg0g40v8rwcqp3nrl3l0zs2ln363pke
wisdom secret wood ice among wine atom chalk author age satisfy visit bread scan firm table sure refuse kit mesh alpha typical primary dress
val7
osmo1zhejumsn39xaamm2qyujzftvh4fskd0vjz7wmk
start infant cash salon pyramid drill caught cheap mixture accident kind treat also since inquiry muffin deputy embark gadget dirt match match split charge
Beta Was this translation helpful? Give feedback.
All reactions