feat(nuget)!: Split the product / technology namespace from the name

Use up to two namespace nodes from the name that identify the company and product / technology as defined at [1] as the namespace. This allows to write curations with empty name and version that affect a whole product / technology, and to set e.g. a concluded license for all "Microsoft.AspNetCore" packages. [1]: https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-namespaces Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Sep 13, 2023 · ccea3a1 · ccea3a1
1 parent 5fc5e54
commit ccea3a1
Show file tree

Hide file tree

Showing 8 changed files with 251 additions and 157 deletions.
diff --git a/plugins/package-managers/nuget/src/funTest/assets/dotnet-expected-output.yml b/plugins/package-managers/nuget/src/funTest/assets/dotnet-expected-output.yml
@@ -18,10 +18,10 @@ project:
   scopes:
   - name: "net45"
     dependencies:
-    - id: "NuGet::System.Runtime.CompilerServices.Unsafe:4.5.3"
-    - id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
+    - id: "NuGet:System.Runtime:CompilerServices.Unsafe:4.5.3"
+    - id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
 packages:
-- id: "NuGet::System.Runtime.CompilerServices.Unsafe:4.5.3"
+- id: "NuGet:System.Runtime:CompilerServices.Unsafe:4.5.3"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -54,7 +54,7 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
+- id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"

diff --git a/plugins/package-managers/nuget/src/funTest/assets/dotnet-license-expected-output.yml b/plugins/package-managers/nuget/src/funTest/assets/dotnet-license-expected-output.yml
@@ -18,9 +18,9 @@ project:
   scopes:
   - name: "netstandard2.0"
     dependencies:
-    - id: "NuGet::Newtonsoft.Json:13.0.2"
+    - id: "NuGet:Newtonsoft:Json:13.0.2"
 packages:
-- id: "NuGet::Newtonsoft.Json:13.0.2"
+- id: "NuGet:Newtonsoft:Json:13.0.2"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "James Newton-King"

diff --git a/plugins/package-managers/nuget/src/funTest/assets/dotnet-many-deps-expected-output.yml b/plugins/package-managers/nuget/src/funTest/assets/dotnet-many-deps-expected-output.yml
@@ -18,18 +18,18 @@ project:
   scopes:
   - name: "net48"
     dependencies:
-    - id: "NuGet::Microsoft.Bcl.AsyncInterfaces:7.0.0"
-    - id: "NuGet::System.Buffers:4.5.1"
-    - id: "NuGet::System.Memory:4.5.5"
-    - id: "NuGet::System.Net.Http.Json:7.0.0"
-    - id: "NuGet::System.Numerics.Vectors:4.5.0"
-    - id: "NuGet::System.Runtime.CompilerServices.Unsafe:6.0.0"
-    - id: "NuGet::System.Text.Encodings.Web:7.0.0"
-    - id: "NuGet::System.Text.Json:7.0.2"
-    - id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
-    - id: "NuGet::System.ValueTuple:4.5.0"
+    - id: "NuGet:Microsoft.Bcl:AsyncInterfaces:7.0.0"
+    - id: "NuGet:System:Buffers:4.5.1"
+    - id: "NuGet:System:Memory:4.5.5"
+    - id: "NuGet:System.Net:Http.Json:7.0.0"
+    - id: "NuGet:System.Numerics:Vectors:4.5.0"
+    - id: "NuGet:System.Runtime:CompilerServices.Unsafe:6.0.0"
+    - id: "NuGet:System.Text:Encodings.Web:7.0.0"
+    - id: "NuGet:System.Text:Json:7.0.2"
+    - id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
+    - id: "NuGet:System:ValueTuple:4.5.0"
 packages:
-- id: "NuGet::Microsoft.Bcl.AsyncInterfaces:7.0.0"
+- id: "NuGet:Microsoft.Bcl:AsyncInterfaces:7.0.0"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -61,7 +61,7 @@ packages:
     url: "https://github.com/dotnet/runtime.git"
     revision: "d099f075e45d2aa6007a22b71b45a08758559f80"
     path: ""
-- id: "NuGet::System.Buffers:4.5.1"
+- id: "NuGet:System:Buffers:4.5.1"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -94,7 +94,7 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.Memory:4.5.5"
+- id: "NuGet:System:Memory:4.5.5"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -128,7 +128,40 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.Net.Http.Json:7.0.0"
+- id: "NuGet:System:ValueTuple:4.5.0"
+  purl: "pkg:nuget/[email protected]"
+  authors:
+  - "Microsoft"
+  declared_licenses:
+  - "https://github.com/dotnet/corefx/blob/master/LICENSE.TXT"
+  declared_licenses_processed:
+    spdx_expression: "MIT"
+    mapped:
+      https://github.com/dotnet/corefx/blob/master/LICENSE.TXT: "MIT"
+  description: "Provides the System.ValueTuple structs, which implement the underlying\
+    \ types for tuples in C# and Visual Basic."
+  homepage_url: "https://dot.net/"
+  binary_artifact:
+    url: "https://api.nuget.org/v3-flatcontainer/system.valuetuple/4.5.0/system.valuetuple.4.5.0.nupkg"
+    hash:
+      value: "fa00ebb5045d12c51274f64411c551981beceb1266a8606a4731063109b95ea1f15939197bf3d2ba899db61e593dc39bfce876908bba34286823525093ae3d8e"
+      algorithm: "SHA-512"
+  source_artifact:
+    url: ""
+    hash:
+      value: ""
+      algorithm: ""
+  vcs:
+    type: ""
+    url: ""
+    revision: ""
+    path: ""
+  vcs_processed:
+    type: ""
+    url: ""
+    revision: ""
+    path: ""
+- id: "NuGet:System.Net:Http.Json:7.0.0"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -159,7 +192,7 @@ packages:
     url: "https://github.com/dotnet/runtime.git"
     revision: "d099f075e45d2aa6007a22b71b45a08758559f80"
     path: ""
-- id: "NuGet::System.Numerics.Vectors:4.5.0"
+- id: "NuGet:System.Numerics:Vectors:4.5.0"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -192,7 +225,7 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.Runtime.CompilerServices.Unsafe:6.0.0"
+- id: "NuGet:System.Runtime:CompilerServices.Unsafe:6.0.0"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -223,7 +256,7 @@ packages:
     url: "https://github.com/dotnet/runtime.git"
     revision: "4822e3c3aa77eb82b2fb33c9321f923cf11ddde6"
     path: ""
-- id: "NuGet::System.Text.Encodings.Web:7.0.0"
+- id: "NuGet:System.Text:Encodings.Web:7.0.0"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -254,7 +287,7 @@ packages:
     url: "https://github.com/dotnet/runtime.git"
     revision: "d099f075e45d2aa6007a22b71b45a08758559f80"
     path: ""
-- id: "NuGet::System.Text.Json:7.0.2"
+- id: "NuGet:System.Text:Json:7.0.2"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -289,7 +322,7 @@ packages:
     url: "https://github.com/dotnet/runtime.git"
     revision: "0a2bda10e81d901396c3cff95533529e3a93ad47"
     path: ""
-- id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
+- id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -322,36 +355,3 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.ValueTuple:4.5.0"
-  purl: "pkg:nuget/[email protected]"
-  authors:
-  - "Microsoft"
-  declared_licenses:
-  - "https://github.com/dotnet/corefx/blob/master/LICENSE.TXT"
-  declared_licenses_processed:
-    spdx_expression: "MIT"
-    mapped:
-      https://github.com/dotnet/corefx/blob/master/LICENSE.TXT: "MIT"
-  description: "Provides the System.ValueTuple structs, which implement the underlying\
-    \ types for tuples in C# and Visual Basic."
-  homepage_url: "https://dot.net/"
-  binary_artifact:
-    url: "https://api.nuget.org/v3-flatcontainer/system.valuetuple/4.5.0/system.valuetuple.4.5.0.nupkg"
-    hash:
-      value: "fa00ebb5045d12c51274f64411c551981beceb1266a8606a4731063109b95ea1f15939197bf3d2ba899db61e593dc39bfce876908bba34286823525093ae3d8e"
-      algorithm: "SHA-512"
-  source_artifact:
-    url: ""
-    hash:
-      value: ""
-      algorithm: ""
-  vcs:
-    type: ""
-    url: ""
-    revision: ""
-    path: ""
-  vcs_processed:
-    type: ""
-    url: ""
-    revision: ""
-    path: ""
diff --git a/...managers/nuget/src/funTest/assets/dotnet-with-csproj-and-nuget-config-expected-output.yml b/...managers/nuget/src/funTest/assets/dotnet-with-csproj-and-nuget-config-expected-output.yml
@@ -18,9 +18,9 @@ project:
   scopes:
   - name: "net7.0"
     dependencies:
-    - id: "NuGet::xunit.analyzers:1.2.0-pre.7"
+    - id: "NuGet:xunit:analyzers:1.2.0-pre.7"
 packages:
-- id: "NuGet::xunit.analyzers:1.2.0-pre.7"
+- id: "NuGet:xunit:analyzers:1.2.0-pre.7"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "jnewkirk,bradwilson,marcind"

diff --git a/plugins/package-managers/nuget/src/funTest/assets/dotnet-with-nuspec-expected-output.yml b/plugins/package-managers/nuget/src/funTest/assets/dotnet-with-nuspec-expected-output.yml
@@ -18,10 +18,10 @@ project:
   scopes:
   - name: "net45"
     dependencies:
-    - id: "NuGet::System.Runtime.CompilerServices.Unsafe:4.5.3"
-    - id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
+    - id: "NuGet:System.Runtime:CompilerServices.Unsafe:4.5.3"
+    - id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
 packages:
-- id: "NuGet::System.Runtime.CompilerServices.Unsafe:4.5.3"
+- id: "NuGet:System.Runtime:CompilerServices.Unsafe:4.5.3"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"
@@ -54,7 +54,7 @@ packages:
     url: ""
     revision: ""
     path: ""
-- id: "NuGet::System.Threading.Tasks.Extensions:4.5.4"
+- id: "NuGet:System.Threading:Tasks.Extensions:4.5.4"
   purl: "pkg:nuget/[email protected]"
   authors:
   - "Microsoft"