Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing tests #10

Open
1 of 3 tasks
UlisesGascon opened this issue Feb 17, 2023 · 2 comments
Open
1 of 3 tasks

Add Missing tests #10

UlisesGascon opened this issue Feb 17, 2023 · 2 comments
Assignees
@UlisesGascon
Labels
enhancement New feature or request
Milestone
v2.0.0-beta

Comments

@UlisesGascon
Copy link
Member

UlisesGascon commented Feb 17, 2023 •
edited
Loading

Testing Strategy:

  • Move not critical parts as external libraries with a proper testing (minimal for v2-beta1)
  • Let's increase the test coverage from the action itself (minimal for v2)
  • Let's cover scenarios in e2e
@UlisesGascon UlisesGascon self-assigned this Feb 17, 2023
@UlisesGascon UlisesGascon converted this from a draft issue Feb 17, 2023
@UlisesGascon UlisesGascon added the enhancement New feature or request label Feb 17, 2023
@UlisesGascon UlisesGascon added this to the v2.0.0 milestone Feb 17, 2023
@UlisesGascon UlisesGascon moved this from 📋 Backlog to 🔖 Ready in Backlog OSSF Scorecard Monitor Feb 18, 2023
@UlisesGascon UlisesGascon mentioned this issue Feb 21, 2023
Merged
@UlisesGascon UlisesGascon removed this from the v2.0.0-beta1 milestone Feb 23, 2023
KoolTheba added a commit to KoolTheba/openssf-scorecard-monitor that referenced this issue Feb 24, 2023
@KoolTheba
test: added unit test for generateReportContent utility
611de75 
- Relates ossf#10
@KoolTheba KoolTheba mentioned this issue Feb 24, 2023
Merged
@KoolTheba
Copy link
Collaborator

KoolTheba commented Feb 24, 2023 •
edited
Loading

Hi @UlisesGascon 👋
I've added a unit test for utility generateReportContent in the PR #32 😄

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Mar 31, 2023 •
edited
Loading

Thanks to @rajbos in #51 we can start moving into the E2E testing. The approach will be slightly different that the typical E2E with frameworks like Jest or Cypress but it will be good enough to grant that new collaborators can contribute and we can merge the PRs fast.

So this become again an initiative to be completed before the final 2.0.0 release 🎉

@UlisesGascon UlisesGascon added this to the v2.0.0-beta milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UlisesGascon UlisesGascon

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0-beta
Development

No branches or pull requests
2 participants
@UlisesGascon @KoolTheba