BUG: fix linter errors

[azeemshaikh38]

We have lot of linter errors from our current GolangCI config, and many useful linters have been disabled. We need to fix these errors and enable them for future.

[gaonkar-adi-wipro]

Hi Azeem,
I have fixed the linter issues and created a pull request for review (#128 )

Would appreciate your feedback on the same!

[azeemshaikh38]

Thanks for your contribution @gaonkar-adi-wipro. Although, this issue is meant for the Golang linter errors coming from the GolangCI config here. I have updated my previous comment to clarify this.

[gliptak]

is this still outstanding?

https://github.com/ossf/scorecard-webapp/actions/runs/7905693652/job/21578875246

  Running [/home/runner/golangci-lint-1.56.1-linux-amd64/golangci-lint run --out-format=github-actions --config=.golangci.yml] in [] ...
  golangci-lint found no issues
  Ran golangci-lint in 37110ms

[spencerschrock]

is this still outstanding?

My understanding is that some of the linters were disabled in #105, and then deleted in #159 before they could be re-enabled. So there may be issues still. While we recently reviewed the ossf/scorecard .golangci.yml file, I'm not sure this one has been reviewed in a while.

Of the deleted linters:

• Probably worthwhile:
  • errcheck, probably useful to fix and turn on
  • govet is usually good, although we may want to disable the fieldalignment portion or fix the occurences.
• debatable value:
  • gocritic, some of these are fine. some are eh
  • revive
  • gocognit, would. need to fix some of the problematic functions
  • wrapcheck