Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ossia-max] Feature request: Package version #806

Open
maybites opened this issue Nov 20, 2022 · 1 comment
Open

[ossia-max] Feature request: Package version #806

maybites opened this issue Nov 20, 2022 · 1 comment
Assignees

Comments

@maybites
Copy link
Collaborator

Hi

currently the version tag inside the package is used to store the github commit:

"version" : "@GIT_SHA@",

but when one is looking at the package, this is not useful for the user (or me for instance: I parse this info to do a version check for dependency packages) to see which version is actually installed.

Would it be possible to use a different key to store the commit-hash instead, and store the actual release nummber inside it?

@jcelerier jcelerier self-assigned this Nov 20, 2022
@jcelerier
Copy link
Member

makes sense yes. can try to turn it into a git tag if it's a commit that comes from a tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants