Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ossia-max] v.2.0.0-rc load-time has increased by 10x from previouse version(s) #813

Open
navid opened this issue Dec 13, 2022 · 11 comments

Comments

@navid
Copy link
Collaborator

navid commented Dec 13, 2022

One of my patches that opens in 2.5 minuets with version "ossia-2022-11-20-17-18" now takes around 22 minutes with the latest v.2.0.0-rc

Similarly, another test patch by Peter that opens in 1 minute in version "2022-1-25-38" now takes 10 min to open.

All of this was triply tested and confirmed on three different machines by Evan, Navid, and Peter.

So we are going to a previous version of ossia now: 2022-1-25-38

@petervanhaaften
Copy link
Collaborator

ossia-test-4osc.zip
Here is my test patch that takes 10min to load on Ossia-max 2.0.0rc2, vs ~1min on Ossia "2022-1-25-38".

@navid navid changed the title Ossia-max v.2.0.0-rc load-time has increased by 10x from previouse version(s) [Ossia-max] v.2.0.0-rc load-time has increased by 10x from previouse version(s) Dec 13, 2022
@evanmtp
Copy link
Contributor

evanmtp commented Dec 13, 2022

I decided to force quit Max because it was taking >10 minutes to load the patch Peter just posted. Here's the crash log:

https://gist.github.com/evanmtp/d312d30e9095e4ae0f712f387decf6da

@jcelerier
Copy link
Member

Can you folk check that you don't have ossia.attribute objects in there ? I think this is what we had found that was causing the huge load times

@jcelerier
Copy link
Member

Also can you send me the commit number it says when you load 2022-1-25-38 in Max ?

@petervanhaaften
Copy link
Collaborator

Hi yes thank you JMC. The Ossia commit number reads "build SHA : b69d066". I can confirm there is no ossia.attribute involved.... I'm not sure yet what that object is about:)

@jcelerier
Copy link
Member

hmmm this is very weird, there's absolutely no difference in terms of general ossia max objects between b69d066 and v2.0.0-rc2 ; ossia.cue has a few fixes but everything else did not change

@petervanhaaften
Copy link
Collaborator

petervanhaaften commented Dec 13, 2022 via email

@petervanhaaften
Copy link
Collaborator

petervanhaaften commented Dec 13, 2022

Hi JMC so that is interesting info re: small changes between b69d066 & 65c3eeb
We have tested this on 3 computers but in any case, I tested both versions again with the provided test patch.
In 65c3eeb I see a load time of 10 minutes 22 seconds.
In b69d066 I see a load time of 1 minute 15 seconds.
Very weird... indeed :))

@jcelerier
Copy link
Member

hmmm, I'm wondering if I may have left some stuff uncommmitted on my mac... are some of you in TML?

@petervanhaaften
Copy link
Collaborator

Hiya not today, but we both should be around TML tomorrow....

@jcelerier
Copy link
Member

heya, ccan any of you try by removing the ossia.attribute.mxo object from the ossia package to check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants