Hw13 #1149
Open
Hw13 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemin
suggested changes
Mar 10, 2024
|
|
||
| declare(strict_types=1); | ||
|
|
||
| include_once 'vendor/autoload.php'; |
| */ | ||
| private static function getDB() | ||
| { | ||
| return new \PDO('mysql:host=localhost;dbname=my_database', 'username', 'password'); |
There was a problem hiding this comment.
Нужно создать во вне и инъектировать как зависимость.
|
|
||
| public static function getAllUsers() | ||
| { | ||
| $db = self::getDB(); |
There was a problem hiding this comment.
Массовая подгрузка идёт мимо identity map. В итоге я могу всё загрузить и потом запросить все данные по из id, и это повлечёт хождение в БД.
| return new \PDO('mysql:host=localhost;dbname=my_database', 'username', 'password'); | ||
| } | ||
|
|
||
| public static function getAllUsers() |
There was a problem hiding this comment.
Обратите внимание на текст задания:
Паттерн должен содержать метод массового получения информации из таблицы, результат которого возвращается в виде коллекции.
Вы возвращаете просто массив, а не коллекцию.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.