Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Model Type Declarations #38

Open
loganliffick opened this issue Jun 12, 2024 · 2 comments
Open

Expanding Model Type Declarations #38

loganliffick opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@loganliffick
Copy link
Contributor

Describe the bug
When generating models, certain type declarations are omitted, specifically noted with Date and number.

Please note: this may just be a SQLite issue.

To Reproduce

  1. Set up SQLite db in Outerbase
  2. Make sure you have a column set to number
  3. run sync-models in your app
  4. check ./models and see if column type shows correctly (if I'm correct, it won't)
@Brayden Brayden self-assigned this Jun 19, 2024
@Brayden Brayden added bug Something isn't working good first issue Good for newcomers labels Jun 19, 2024
@Brayden
Copy link
Member

Brayden commented Jun 19, 2024

@caleb-mabry
Copy link
Contributor

One cool thing I've noticed here is how Sequelize has these identified as different objects when you use the DataTypes class. That allows for additional checks with specific dialects if you so want!
https://github.com/sequelize/sequelize/blob/main/packages/core/src/abstract-dialect/data-types.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants