Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soft disable mismatch indicator for sqljs driver #148

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

rentalhost
Copy link
Contributor

Since this driver does not report the column type, the type should be treated as undefined, which causes the type analysis system to be disabled for this driver.


Since you mentioned that you’re implementing MySQL support, it’s not necessary to approve this PR right now. When you're ready, let me know, and I’ll do a rebase and adjust whatever is needed.

As for this PR, in short, I just removed the internal indication that forced the TEXT type for all columns when using sqljs to be undefined. This way, the mismatch indicator system will be disabled.

I also migrated the code I had created in global.css to pure Tailwind, which I believe is ideal. I also fixed a typo.

Since this driver does not report the column type, the type should be treated as `undefined`, which causes the type analysis system to be disabled for this driver.
Copy link

vercel bot commented Aug 16, 2024

@rentalhost is attempting to deploy a commit to the Mediaload Team on Vercel.

A member of the Team first needs to authorize it.

@invisal
Copy link
Collaborator

invisal commented Aug 17, 2024

Since you mentioned that you’re implementing MySQL support, it’s not necessary to approve this PR right now. When you're ready, let me know, and I’ll do a rebase and adjust whatever is needed.

@rentalhost thanks. your support is very much appreciated and impressive. Hopefully, I can finish MySQL implement support this weekend.

Copy link
Collaborator

@invisal invisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge this one first. Rework mysql takes more time than I thought. But once it is finished, LibSQL Studio should not only able to add MySQL and Postgre, we will be able to support Sqlite ATTACH :)

@invisal invisal merged commit 9872fc6 into outerbase:develop Aug 22, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants