Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when creating patch #16047

Closed
gabrielmaldi opened this issue Dec 29, 2024 · 5 comments · Fixed by #16064
Closed

Crash when creating patch #16047

gabrielmaldi opened this issue Dec 29, 2024 · 5 comments · Fixed by #16064
Labels
bun patch confirmed bug We can reproduce this issue crash An issue that could cause a crash

Comments

@gabrielmaldi
Copy link

How can we reproduce the crash?

No response

Relevant log output

Stack Trace (bun.report)

Bun v1.1.42-canary (18ac7f9) on macos aarch64 [PatchCommand]

Segmentation fault at address 0x4000000000000B0

  • 1 unknown/js code
  • src.http.HTTPThread.processEvents
  • Thread.PosixThreadImpl.spawn__anon_177490.Instance.entryFn

Features: dotenv, spawn

Sentry Issue: BUN-AGC

@gabrielmaldi gabrielmaldi added the crash An issue that could cause a crash label Dec 29, 2024
@github-actions github-actions bot added the macOS An issue that occurs on macOS label Dec 29, 2024
@dylan-conway
Copy link
Member

Thanks for the bug report. Could you share the package.json for this project and bun patch command you are running?

@gabrielmaldi
Copy link
Author

Hello, @dylan-conway. Yes, of course:

{
  "type": "module",
  "dependencies": {
    "@arcjet/next": "^1.0.0-alpha.34",
    "@clerk/nextjs": "^6.9.6",
    "@clerk/themes": "^2.2.3",
    "@mailchimp/mailchimp_marketing": "^3.0.80",
    "@mantine/carousel": "^7.15.2",
    "@mantine/colors-generator": "^7.15.2",
    "@mantine/core": "^7.15.2",
    "@mantine/dates": "^7.15.2",
    "@mantine/form": "^7.15.2",
    "@mantine/hooks": "^7.15.2",
    "@mantine/modals": "^7.15.2",
    "@mantine/notifications": "^7.15.2",
    "@mantine/nprogress": "^7.15.2",
    "@portabletext/react": "^3.2.0",
    "@portabletext/types": "^2.0.13",
    "@react-email/components": "^0.0.31",
    "@sanity/image-url": "^1.1.0",
    "@sanity/webhook": "^4.0.4",
    "@sentry/nextjs": "^8.47.0",
    "@t3-oss/env-nextjs": "^0.11.1",
    "@tabler/icons-react": "^3.26.0",
    "@talkjs/react": "^0.1.11",
    "@vercel/analytics": "^1.4.1",
    "@vercel/kv": "^3.0.0",
    "@vercel/postgres": "^0.10.0",
    "add-to-calendar-button": "^2.8.0",
    "async": "^3.2.6",
    "change-case": "^5.4.4",
    "chroma-js": "^3.1.2",
    "clsx": "^2.1.1",
    "conditional-wrap": "^1.0.2",
    "dayjs": "^1.11.13",
    "drizzle-orm": "^0.38.3",
    "embla-carousel-autoplay": "7.1.0",
    "embla-carousel-react": "7.1.0",
    "jsdom": "^25.0.1",
    "jsonwebtoken": "^9.0.2",
    "lodash": "^4.17.21",
    "mantine-datatable": "7.15.1",
    "next": "^15.1.3",
    "next-sanity": "^9.8.30",
    "next-view-transitions": "^0.3.4",
    "react": "^19.0.0",
    "react-canvas-confetti": "^2.0.7",
    "react-dom": "^19.0.0",
    "react-email": "^3.0.4",
    "react-geolocated": "^4.3.0",
    "react-google-autocomplete": "^2.7.3",
    "react-google-places-autocomplete": "^4.1.0",
    "remix-params-helper": "^0.5.1",
    "resend": "^4.0.1",
    "server-only": "^0.0.1",
    "sqids": "^0.3.0",
    "stripe": "^17.5.0",
    "superjson": "^2.2.2",
    "svix": "^1.44.0",
    "swr": "^2.3.0",
    "talkjs": "^0.33.0",
    "vercel": "^39.2.2",
    "zod": "^3.24.1"
  },
  "devDependencies": {
    "@babel/core": "^7.26.0",
    "@next/bundle-analyzer": "15.1.3",
    "@portabletext/to-html": "^2.0.13",
    "@total-typescript/ts-reset": "^0.6.1",
    "@types/async": "^3.2.24",
    "@types/bun": "^1.1.14",
    "@types/jsdom": "^21.1.7",
    "@types/jsonwebtoken": "^9.0.7",
    "@types/lodash": "^4.17.13",
    "@types/mailchimp__mailchimp_marketing": "^3.0.20",
    "@types/node": "^22.10.2",
    "@types/react": "npm:types-react@rc",
    "@types/react-dom": "npm:types-react-dom@rc",
    "@types/superagent": "^8.1.9",
    "babel-loader": "^9.2.1",
    "babel-plugin-react-compiler": "^19.0.0-beta-b2e8e9c-20241220",
    "drizzle-kit": "^0.30.1",
    "eslint-plugin-deprecated-props": "^0.1.3",
    "eslint-plugin-deprecation": "^3.0.0",
    "eslint-plugin-react-compiler": "^19.0.0-beta-b2e8e9c-20241220",
    "jiti": "^2.4.2",
    "pg": "^8.13.1",
    "postcss": "^8.4.49",
    "postcss-preset-mantine": "^1.17.0",
    "postcss-simple-vars": "^7.0.1",
    "prettier": "^3.4.2",
    "type-fest": "^4.31.0",
    "typescript": "^5.7.2",
    "typescript-plugin-css-modules": "^5.1.0"
  },
  "optionalDependencies": {
    "@biomejs/biome": "^1.9.4",
    "@next/eslint-plugin-next": "^15.1.3",
    "@storybook/addon-essentials": "^8.4.7",
    "@storybook/addon-styling-webpack": "^1.0.1",
    "@storybook/blocks": "^8.4.7",
    "@storybook/nextjs": "^8.4.7",
    "@storybook/react": "^8.4.7",
    "@testing-library/dom": "^10.4.0",
    "@testing-library/jest-dom": "^6.6.3",
    "@testing-library/react": "^16.1.0",
    "@testing-library/user-event": "^14.5.2",
    "@types/google.maps": "^3.58.1",
    "@types/jest": "^29.5.14",
    "@typescript-eslint/eslint-plugin": "^7.17.0",
    "@typescript-eslint/parser": "^7.17.0",
    "eslint": "^8.57.0",
    "eslint-config-airbnb": "^19.0.4",
    "eslint-config-airbnb-typescript": "^18.0.0",
    "eslint-config-mantine": "^3.2.0",
    "eslint-plugin-import": "^2.31.0",
    "eslint-plugin-jest": "^28.10.0",
    "eslint-plugin-jsx-a11y": "^6.10.2",
    "eslint-plugin-react": "^7.37.3",
    "eslint-plugin-react-hooks": "^5.1.0",
    "eslint-plugin-testing-library": "^7.1.1",
    "eslint-plugin-unused-imports": "^4.1.4",
    "jest": "^29.7.0",
    "jest-environment-jsdom": "^29.7.0",
    "localtunnel": "^2.0.2",
    "storybook": "^8.4.7",
    "storybook-dark-mode": "^4.0.2",
    "stylelint": "^16.12.0",
    "stylelint-config-standard-scss": "^14.0.0",
    "ts-jest": "^29.2.5"
  },
  "trustedDependencies": [
    "@biomejs/biome",
    "@clerk/shared",
    "@parcel/watcher",
    "@sentry/cli",
    "@swc/core",
    "bufferutil",
    "core-js-pure",
    "es5-ext",
    "esbuild",
    "sharp",
    "utf-8-validate"
  ],
  "patchedDependencies": {
    "[email protected]": "patches/[email protected]"
  },
  "overrides": {
    "@types/react": "npm:types-react@rc",
    "@types/react-dom": "npm:types-react-dom@rc"
  }
}
bun patch @mantine/core
bun patch --commit 'node_modules/@mantine/core'

The file I edit is:

node_modules/@mantine/core/esm/core/MantineProvider/suppress-nextjs-warning.mjs

The contents of the edited file (// ToDo and the next line are added):

'use client';
function suppressNextjsWarning() {
  const originalError = console.error;
  console.error = (...args) => {
    // ToDo: remove this when it's no longer needed
    if (args.length >= 1 && typeof args[0] === "string" && (args[0].includes("Use PascalCase for React components") || args[0].includes("start its name with an uppercase letter"))) return;

    if (args.length > 1 && typeof args[0] === "string" && args[0].toLowerCase().includes("extra attributes from the server") && typeof args[1] === "string" && args[1].toLowerCase().includes("data-mantine-color-scheme")) ; else {
      originalError(...args);
    }
  };
}

export { suppressNextjsWarning };
//# sourceMappingURL=suppress-nextjs-warning.mjs.map

Thanks!

@dylan-conway dylan-conway added bun patch confirmed bug We can reproduce this issue and removed macOS An issue that occurs on macOS labels Dec 30, 2024
@gabrielmaldi
Copy link
Author

Always amazed by the speed of the Bun team! Thanks

@dylan-conway
Copy link
Member

@gabrielmaldi thanks for sharing package.json+command, made fixing this bug much easier

@gabrielmaldi
Copy link
Author

Just tested on the latest canary and can confirm it worked flawlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bun patch confirmed bug We can reproduce this issue crash An issue that could cause a crash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants