Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kms): keep data after unmount component on credential creation #13518

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(kms): keep data after unmount component on credential creation #13518

merged 1 commit into from
Oct 10, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Oct 9, 2024 •
edited
Loading

Question Answer
Branch? feat/key-management-service-B3
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15319
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added enabler bug Something isn't working labels Oct 9, 2024
@vovh vovh marked this pull request as ready for review October 9, 2024 13:52
@vovh vovh requested review from a team as code owners October 9, 2024 13:52
@vovh vovh requested review from kqesar, frenautvh, tibs245, oalkabouss and ghyenne and removed request for a team October 9, 2024 13:52
@vovh vovh self-assigned this Oct 10, 2024
@vovh vovh requested a review from darsene October 10, 2024 08:29
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch from 796b2e3 to 9158906 Compare October 10, 2024 08:43
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 10, 2024
@vovh
fix(kms): keep data after unmount component on credential creation
c47851b 
ref: MANAGER-15319

Signed-off-by: Vincent BONMARCHAND <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vovh vovh merged commit 3720f80 into feat/key-management-service-B3 Oct 10, 2024
14 checks passed
@vovh vovh deleted the fix/MANAGER-15319 branch October 10, 2024 13:28
rjamet-ovh pushed a commit that referenced this pull request Oct 15, 2024
@vovh
fix(kms): keep data after unmount component on credential creation (#…
a06e2b8 
…13518)

ref: MANAGER-15319

Signed-off-by: Vincent BONMARCHAND <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@darsene darsene darsene approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@vovh vovh

Labels
bug Something isn't working enabler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vovh @darsene @rjamet-ovh