Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hpc-vmware-managed-vcd): revert fix datagrid labels (#13502) #13555

Merged
merged 2 commits into from
Oct 11, 2024
Merged

feat(hpc-vmware-managed-vcd): revert fix datagrid labels (#13502) #13555

merged 2 commits into from
Oct 11, 2024

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Oct 10, 2024

desc: This reverts commit d50446c. (#13502)
ref: MANAGER-15439

Question Answer
Branch? feat/hpc-vcd-beta
Bug fix? yes
New feature? no
Breaking change? no
Tickets fix/MANAGER-15439
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

feat(hpc-vmware-managed-vcd): revert fix compute datagrid labels (#13502
0a9bf2c 
)

  desc: This reverts commit d50446c. (#13502)
  ref: MANAGER-15439

Signed-off-by: Paul Dickerson <[email protected]>
@pauldkn pauldkn requested a review from a team as a code owner October 10, 2024 15:03
@pauldkn pauldkn requested review from MaximeBajeux, oalkabouss and ghyenne and removed request for a team October 10, 2024 15:03
@github-actions github-actions bot added translation required bug Something isn't working labels Oct 10, 2024
feat(hpc-vmware-managed-vcd): update vHost column name
fb53e5c 
  ref: MANAGER-15439

Signed-off-by: Paul Dickerson <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pauldkn pauldkn merged commit 645a98c into feat/hpc-vcd-beta Oct 11, 2024
13 of 14 checks passed
@pauldkn pauldkn deleted the fix/MANAGER-15439-revert branch October 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@chipp972 chipp972 chipp972 approved these changes

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldkn @chipp972 @darsene