Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated.vrack): add occ as new eligibility service in vrack #13678

Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat(dedicated.vrack): add occ as new eligibility service in vrack #13678

merged 2 commits into from
Nov 29, 2024

Conversation

sachinrameshn
Copy link
Contributor

@sachinrameshn sachinrameshn commented Oct 19, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15301
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add OVH Cloud connect as new eligibility service in vrack section.

Related

  • Trans [CMT-19101]

@sachinrameshn sachinrameshn requested a review from a team as a code owner October 19, 2024 13:16
qpavy
qpavy previously approved these changes Oct 21, 2024
View reviewed changes
tibs245
tibs245 reviewed Oct 21, 2024
View reviewed changes
packages/manager/modules/vrack/src/dashboard/vrack.controller.js
const formattedService = {
...service,
id: service.uuid,
niceName: service.uuid,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
niceName: service.uuid,
displayName: service.uuid,

I'll let you judge the relevance of the suggestion ;)

Copy link
Contributor Author

@sachinrameshn sachinrameshn Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check on this.

@sachinrameshn sachinrameshn requested review from a team as code owners November 6, 2024 09:25
@github-actions github-actions bot added universe-web-cloud universe-telecom dependencies Pull requests that update a dependency file labels Nov 6, 2024
@sachinrameshn sachinrameshn changed the base branch from master to develop November 6, 2024 09:26
@github-actions github-actions bot removed universe-web-cloud universe-telecom dependencies Pull requests that update a dependency file labels Nov 6, 2024
@sachinrameshn sachinrameshn changed the base branch from develop to feat/MANAGER-15301-v1 November 6, 2024 09:35
@sachinrameshn sachinrameshn removed the feature New feature label Nov 6, 2024
@sachinrameshn sachinrameshn changed the base branch from develop to master November 21, 2024 17:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@qpavy qpavy changed the base branch from master to release/infra–w49 November 29, 2024 07:24
@qpavy qpavy merged commit f5292f2 into release/infra–w49 Nov 29, 2024
13 of 16 checks passed
@qpavy qpavy deleted the feat/MANAGER-15301 branch November 29, 2024 07:47
This was referenced Nov 29, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibs245 tibs245 tibs245 left review comments

@tristanwagner tristanwagner tristanwagner approved these changes

@qpavy qpavy qpavy approved these changes

@mhelhali-soufien mhelhali-soufien mhelhali-soufien left review comments

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sachinrameshn @tibs245 @qpavy @tristanwagner @mhelhali-soufien