Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager-react-components): update migration guide version #14120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(manager-react-components): update migration guide version #14120

wants to merge 2 commits into from

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud commented Nov 15, 2024 •
edited
Loading

ref: MANAGER-14622

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix 14622
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

MRC update documentation

Related

@github-actions github-actions bot added the bug Something isn't working label Nov 15, 2024
tristanwagner
tristanwagner previously approved these changes Nov 18, 2024
View reviewed changes
darsene
darsene previously approved these changes Nov 18, 2024
View reviewed changes
fredericvilcot
fredericvilcot previously approved these changes Nov 18, 2024
View reviewed changes
@aboungnaseng-ovhcloud
fix(manager-react-components): update migration guide version
3cc065f 
ref: MANAGER-14622

Signed-off-by: Alex Boungnaseng <[email protected]>
anooparveti
anooparveti requested changes Nov 18, 2024
View reviewed changes
packages/manager-react-components/CHANGELOG.md Outdated Show resolved Hide resolved
packages/manager-react-components/CHANGELOG.md Outdated Show resolved Hide resolved
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the fix/mrc-docs-migration branch 3 times, most recently from 676857b to 1428852 Compare November 18, 2024 14:12
anooparveti
anooparveti reviewed Nov 20, 2024
View reviewed changes
packages/manager-react-components/CHANGELOG.md Outdated
Comment on lines 8 to 11
- Udpate ods version to 18.3.0 ([395ab60](https://github.com/ovh/manager/commit/395ab60fe2ac45f59eed9b54f1fa2c326173a548))
- Move ods to peerDependencies ([be434c4](https://github.com/ovh/manager/commit/be434c4f3f60b37adf64f90fdce0e827fe61d885))
- Update ODS version in Generator ([035a111](https://github.com/ovh/manager/commit/035a11128365638999ce0943d01ca8fe56d8d8f8))
- Pre-build documentation ([b419872](b419872b2f58ef18f8ffb78cc0f5db3218142a3f))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Udpate ods version to 18.3.0 ([395ab60](https://github.com/ovh/manager/commit/395ab60fe2ac45f59eed9b54f1fa2c326173a548))
- Move ods to peerDependencies ([be434c4](https://github.com/ovh/manager/commit/be434c4f3f60b37adf64f90fdce0e827fe61d885))
- Update ODS version in Generator ([035a111](https://github.com/ovh/manager/commit/035a11128365638999ce0943d01ca8fe56d8d8f8))
- Pre-build documentation ([b419872](b419872b2f58ef18f8ffb78cc0f5db3218142a3f))
### BREAKING CHANGE
- **manager-react-components:** bump ODS V18 (#14035) ([377f420](https://github.com/ovh/manager/commit/377f4206c7e9a4f43aec27b25a1a617e62aa5dba))

anooparveti
anooparveti requested changes Nov 21, 2024
View reviewed changes
packages/manager-react-components/CHANGELOG.md Outdated
Comment on lines 6 to 26
## [2.2.0](https://github.com/ovh/manager/compare/@ovh-ux/manager-react-components@2.1.0...@ovh-ux/manager-react-components@2.2.0) (2024-11-15)

**Note:** Version bump only for package @ovh-ux/manager-react-components
### BREAKING CHANGE

- **manager-react-components:** bump ODS V18 (#14035) ([377f420](https://github.com/ovh/manager/commit/377f4206c7e9a4f43aec27b25a1a617e62aa5dba))

# [2.1.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-11-13)

### Reverts

- Revert "Upgrade ods version 18" ([a31810d](https://github.com/ovh/manager/commit/a31810d871f1e5625804cb5a9e61adca56b24084))
- Revert "Update generator" ([9b01d07](https://github.com/ovh/manager/commit/9b01d0716a28a258048ec51f253d32ca846e2899))

### Bug Fixes

- Fix bump ods 18 issues ([72d937f](https://github.com/ovh/manager/commit/72d937f20792d1c668f43dd7cc023c80f93cf1a0))

# [1.41.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-11-13)

### Bug Fixes

- Version bump only for package @ovh-ux/manager-react-components ([b86394f](https://github.com/ovh/manager/commit/b86394f1d186821084237348f2001fa930fee0f8))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboungnaseng-ovhcloud we introduced the breaking change for 2.1.0. Not 2.2.0.
My previous commit was just a sample and it was not good commits. You need to change it with right commits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aboungnaseng-ovhcloud
feat(manager-react-components): update changelog and doc
418c12d 
ref: MANAGER-14622

Signed-off-by: Alex Boungnaseng <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 21, 2024
anooparveti
anooparveti requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have updated the changelog in #14316. Can you exclude it in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti requested changes

@darsene darsene darsene left review comments

@fredericvilcot fredericvilcot fredericvilcot left review comments

@tristanwagner tristanwagner tristanwagner left review comments

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working has conflicts Has conflicts to resolve before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aboungnaseng-ovhcloud @tristanwagner @anooparveti @fredericvilcot @darsene