Feat/pci rancher add pci rancher id tapc 1024 #14236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-1024 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-1024 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
requested review from
sidlynx,
seven-amid,
qpavy,
ghyenne and
sachinrameshn
SimonChaumet
previously approved these changes
Nov 22, 2024
...ages/manager/apps/pci-rancher/src/components/Table/ClipBoardCell/ClipBoardCell.component.tsx
Outdated
Show resolved
Hide resolved
ref: TAPC-1024 Signed-off-by: Pierre-Philippe <[email protected]>
|
fredericvilcot
approved these changes
Nov 26, 2024
stif59100
reviewed
Nov 27, 2024
| @@ -18,7 +18,8 @@ | |||
| "start": "lerna exec --stream --scope='@ovh-ux/manager-pci-rancher-app' --include-dependencies -- npm run build --if-present", | |||
| "start:dev": "lerna exec --stream --scope='@ovh-ux/manager-pci-rancher-app' --include-dependencies -- npm run dev --if-present", | |||
| "start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/manager-pci-rancher-app' --include-dependencies -- npm run dev:watch --if-present", | |||
| "test": "jest" | |||
| "test": "jest", | |||
There was a problem hiding this comment.
actually on multiple packages for app react we use
"test": "vitest run",
"test:coverage": "vitest run --coverage"
exemple
packages/manager/apps/hpc-vmware-managed-vcd/package.json
packages/manager/apps/vrack-services/package.json
packages/manager/apps/zimbra/package.json
stif59100
approved these changes
Nov 27, 2024
anooparveti
changed the base branch from
develop
to
release/public-cloud-w49
anooparveti
deleted the
feat/pci-rancher_add-pci-rancher-id_tapc-1024
branch
16 tasks
anooparveti
pushed a commit
that referenced
this pull request
Nov 29, 2024
ref: TAPC-1024 Signed-off-by: Pierre-Philippe <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
anooparveti
pushed a commit
that referenced
this pull request
Nov 29, 2024
ref: TAPC-1024 Signed-off-by: Pierre-Philippe <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related