Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring time from the mail with config option back #1135

Closed
prsnbrg opened this issue Sep 20, 2022 · 2 comments
Closed

Bring time from the mail with config option back #1135

prsnbrg opened this issue Sep 20, 2022 · 2 comments

Comments

@prsnbrg
Copy link

prsnbrg commented Sep 20, 2022

Steps to reproduce

  1. Update activity to 2.7.1
  2. Get Activity E-Mail without the time

Expected behaviour

Tell us what should happen

Config option to display the time in the e-mail. By default, only the day is displayed.
Are there any legal regulations that prevent the display of the time?

Actual behaviour

Tell us what happens instead

@phil-davis
Copy link
Contributor

Share expiry always happens effectively at the end of the expiry date. But the processing of that expiry happens whenever the share is next attempted to be accessed, or when the cron job runs. For share expiry the activity time was misleading.

But it seems that the time was removed in all cases. IMO the code should be made smarter, and the time be put back for all activity notifications except share expiry.

Related issue #1131

@pmaier1 FYI

@prsnbrg
Copy link
Author

prsnbrg commented Sep 20, 2022

Sorry for the duplicate.
I will close here and all related comments should be made in #1131

@prsnbrg prsnbrg closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants