You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Regarding this PR #4454, there are several things that can be improved:
Include contentDescription as another parameter in the setAccessibilityRole extension function, so that we avoid implementing AccessibilityDelegateCompat again, like in SortOptionsView
Check if onCreateOptionsMenu can actually be moved to FileFragment and remove it from its subclasses
When setting contentDescription as a concatenation of several Strings, add a space in between so that they form a sentence correctly. Make it in a more Kotlinized way
String <string name="content_description_add_new_content_expanded">"Add new content expanded"</string> shouldn't have the "
String <string name="content_description_sort_by_name_descending">sort by %1$s descending</string> should start by a capital letter to be consistent with its analogue content_description_sort_by_name_ascending
Other refactor that has to do with accessibility but not with role management, regarding #4455:
KeyEvent.KEYCODE_TAB shouldn't be handled like that, since it breaks the navigation model. Tab should be used to move to the next element in the view, not moving to lock_time (which is not always visible)
KeyEvent.KEYCODE_DPAD_DOWN should just move the focus from the toolbar to the first element in the view, if possible, not moving it straight to the custom number keyboard shown in the view. That's how the navigation model works in other views
Check why introducing the numbers with the keyboard makes the passcode visible
Regarding this PR #4454, there are several things that can be improved:
contentDescription
as another parameter in thesetAccessibilityRole
extension function, so that we avoid implementingAccessibilityDelegateCompat
again, like inSortOptionsView
onCreateOptionsMenu
can actually be moved toFileFragment
and remove it from its subclassescontentDescription
as a concatenation of several Strings, add a space in between so that they form a sentence correctly. Make it in a more Kotlinized way<string name="content_description_add_new_content_expanded">"Add new content expanded"</string>
shouldn't have the"
<string name="content_description_sort_by_name_descending">sort by %1$s descending</string>
should start by a capital letter to be consistent with its analoguecontent_description_sort_by_name_ascending
Other refactor that has to do with accessibility but not with role management, regarding #4455:
KeyEvent.KEYCODE_TAB
shouldn't be handled like that, since it breaks the navigation model.Tab
should be used to move to the next element in the view, not moving tolock_time
(which is not always visible)KeyEvent.KEYCODE_DPAD_DOWN
should just move the focus from the toolbar to the first element in the view, if possible, not moving it straight to the custom number keyboard shown in the view. That's how the navigation model works in other viewsTASKS
contentDescription
as parameter insetAccessibilityRole
onCreateOptionsMenu
inFileFragment
feasibilitycontent_description_add_new_content_expanded
Stringcontent_description_sort_by_name_descending
StringKeyEvent.KEYCODE_TAB
handlingKeyEvent.KEYCODE_DPAD_DOWN
handlingThe text was updated successfully, but these errors were encountered: