Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 4.1.1 #4189

Merged
merged 11 commits into from
Oct 19, 2023
Merged

[RELEASE] 4.1.1 #4189

merged 11 commits into from
Oct 19, 2023

Conversation

JuancaG05
Copy link
Collaborator

Related Issues

App: #4165


QA

@JuancaG05 JuancaG05 linked an issue Oct 17, 2023 that may be closed by this pull request
20 tasks
@JuancaG05 JuancaG05 force-pushed the release/4.1.1 branch 2 times, most recently from fd12462 to dabd26d Compare October 17, 2023 11:23
@JuancaG05 JuancaG05 marked this pull request as ready for review October 17, 2023 15:23
Copy link
Contributor

@manuelplazaspalacio manuelplazaspalacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment here

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 19, 2023

4.1.1 OK from my side

Approved commits:

app: cde9bb841
library: c82d75b1

Android Studio version:

Giraffe | 2022.3.1 Patch 1

Reports:

vs oC 10.3.2: https://reports.cucumber.io/reports/c5cecd13-d2d5-476c-85a6-99ca70a2b4c4
vs oCIS 4.0.0: https://reports.cucumber.io/reports/3e3420a5-b9ac-48bb-ad73-41039968b83e

Smoke test checklist:

#4165 (comment)

Comments:

Thumbnails fix is a first approach by updating the cache version that triggers a clean up. Ultimate fix is removing the thumbnails cache by replacing for another library/solution. Should be addressed to a different issue.

@JuancaG05 JuancaG05 merged commit 28734b5 into stable Oct 19, 2023
2 checks passed
@JuancaG05 JuancaG05 deleted the release/4.1.1 branch October 19, 2023 13:04
@JuancaG05 JuancaG05 restored the release/4.1.1 branch October 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] 4.1.1
4 participants