-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make announcement center an official app #46
Comments
Well in 8.2 it was not an official app, but it is in 9.0 so from that on it should not get disabled anymore. |
This was an upgrade from 9.0.0 master yesterday to master today (test of the tag column switch from int to string) |
Okay right, the appstore says the app is official, but it's not in shipped.json which is checked on update. The problem is, if we add it there, community people (where the app is not shipped) will have a problem, because for them the app needs to be disabled on update and then grab the new version from the appstore. |
Why is it not shipped in the community version? 😕 - @karlitschek |
Because we don't want to ship everything? |
Then we need to check our core logic - announcing an official app as 3rdparty during update and then disable it sounds totally weird. |
in the future we have to avoid the situation that an app is in the tar in EE and in the app store in CE. this is weird. too late to change the logic now before 9.0 so we have lot keep it for now. in the future we only should have one way to distribute one app. |
So closing, as
Is indeed correct. |
During a upgrade just now I got "Disabled apps: announcement center (3rd party app)".
is this correct? @karlitschek @nickvergessen
The text was updated successfully, but these errors were encountered: