Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make announcement center an official app #46

Closed
MorrisJobke opened this issue Feb 24, 2016 · 8 comments
Closed

Make announcement center an official app #46

MorrisJobke opened this issue Feb 24, 2016 · 8 comments
Labels
Milestone

Comments

@MorrisJobke
Copy link

During a upgrade just now I got "Disabled apps: announcement center (3rd party app)".

is this correct? @karlitschek @nickvergessen

@MorrisJobke MorrisJobke added this to the 9.0-current milestone Feb 24, 2016
@nickvergessen
Copy link
Contributor

Well in 8.2 it was not an official app, but it is in 9.0 so from that on it should not get disabled anymore.

@MorrisJobke
Copy link
Author

This was an upgrade from 9.0.0 master yesterday to master today (test of the tag column switch from int to string)

@nickvergessen
Copy link
Contributor

Okay right, the appstore says the app is official, but it's not in shipped.json which is checked on update.

The problem is, if we add it there, community people (where the app is not shipped) will have a problem, because for them the app needs to be disabled on update and then grab the new version from the appstore.

@MorrisJobke
Copy link
Author

The problem is, if we add it there, community people (where the app is not shipped)

Why is it not shipped in the community version? 😕 - @karlitschek

@nickvergessen
Copy link
Contributor

Because we don't want to ship everything?
It's in the app store, the only reason why it is shipped in EE is because we don't support the appstore there yet. See owncloud/core#19152 (comment) and following

@MorrisJobke
Copy link
Author

Because we don't want to ship everything?

Then we need to check our core logic - announcing an official app as 3rdparty during update and then disable it sounds totally weird.

@karlitschek
Copy link

in the future we have to avoid the situation that an app is in the tar in EE and in the app store in CE. this is weird. too late to change the logic now before 9.0 so we have lot keep it for now. in the future we only should have one way to distribute one app.

@nickvergessen
Copy link
Contributor

So closing, as

is this correct?

Is indeed correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants