Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] COM directory gets synced from server to client #9332

Closed
Talank opened this issue Jan 5, 2022 · 3 comments
Closed

[QA] COM directory gets synced from server to client #9332

Talank opened this issue Jan 5, 2022 · 3 comments

Comments

@Talank
Copy link
Contributor

Talank commented Jan 5, 2022

While testing #9290 (comment) (under the Folders i.e. 2->14), the folder named "COM" gets synced from server to the desktop client.

Expected behaviour

A windows client syncs down folder 'COM'

Actual behaviour

'COM` gets synced

Steps to reproduce

  1. create a folder named COM in server
  2. Check if it gets synced to desktop client

Server configuration

as mentioned in the issue for testplan release desktop 1.10.0

Client configuration

Client version: Version 2.10.0rc3 (build 6417)

Operating system: Windows 10, Version 1809 (OS Build 17763.379)

@TheOneRing
Copy link
Contributor

The restricted file names are:

const QLatin1String win_device_names[] = {
    QLatin1String("CON"), QLatin1String("PRN"), QLatin1String("AUX"), QLatin1String("NUL"),
    QLatin1String("COM1"), QLatin1String("COM2"), QLatin1String("COM3"),
    QLatin1String("COM4"), QLatin1String("COM5"), QLatin1String("COM6"),
    QLatin1String("COM7"), QLatin1String("COM8"), QLatin1String("COM9"),
    QLatin1String("LPT1"), QLatin1String("LPT2"), QLatin1String("LPT3"),
    QLatin1String("LPT4"), QLatin1String("LPT5"), QLatin1String("LPT6"),
    QLatin1String("LPT7"), QLatin1String("LPT8"), QLatin1String("LPT9"),
    QLatin1String("CLOCK$")
};

@Talank
Copy link
Contributor Author

Talank commented Jan 5, 2022

@gabi18 we should update the testplan for this as well.

@Talank
Copy link
Contributor Author

Talank commented Jan 6, 2022

I also need to refactor the tests added in this PR #9258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants