Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pool /notifications when the topbar is not visible #30482

Closed
SamuAlfageme opened this issue Feb 14, 2018 · 3 comments
Closed

Do not pool /notifications when the topbar is not visible #30482

SamuAlfageme opened this issue Feb 14, 2018 · 3 comments
Labels
enhancement feature:notifications junior job performance

Comments

@SamuAlfageme
Copy link

Dumping the contents of #30385 (comment)

I noticed that regular pooling to the /notifications endpoint is also happening under the hood on an open OAuth's "authorize" screen.

As a rule of thumb, I'd say when the top bar (where the notification container is located) is hidden, we should simply not pool this endpoint for events. I'll create an issue.
@DeepDiver1975
Copy link
Member

should go into https://github.com/owncloud/notifications

@SamuAlfageme
Copy link
Author

owncloud/notifications#138

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement feature:notifications junior job performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DeepDiver1975 @SamuAlfageme