Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Support for S3 #27

Open
1 of 2 tasks
IljaN opened this issue Sep 19, 2018 · 5 comments
Open
1 of 2 tasks

Support for S3 #27

IljaN opened this issue Sep 19, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@IljaN
Copy link
Member

IljaN commented Sep 19, 2018

  • Should technically work, need smoke-test
  • Add CI
@IljaN IljaN added the enhancement New feature or request label Sep 19, 2018
@IljaN IljaN added this to the development milestone Sep 19, 2018
@PVince81 PVince81 modified the milestones: development, backlog Sep 20, 2018
@jvillafanez
Copy link
Member

jvillafanez commented Oct 5, 2018

Require full test

  • from local storage to S3
  • from S3 to local storage

That should also cover S3 to S3

@IljaN
Copy link
Member Author

IljaN commented Oct 8, 2018

  • Create custom import process for versions in S3, as S3 native versioning is used.

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2018

Maybe https://github.com/owncloud/core/blob/v10.0.10/lib/public/Files/ObjectStore/IVersionedObjectStorage.php#L77 after getting the storage instance and checking whether it implements this interface.

The interface and impl of S3 would need to be adjusted to also accept the mtime.

As @DeepDiver1975 mentioned today, there is a risk that the underlying native S3 versioning API doesn't support setting specific mtimes...

@jvillafanez
Copy link
Member

Unless there is a stablished public API in core to handle versions, I'd rather not to use anything depending on the implementation, otherwise the behaviour will be different depending on the type of storage we're using.

For now, versions will be created by uploading content to the same location. The mtime will be different, but that's a known limitation regardless of the storage.
If the retention policy is different depending on the storage, that's out of the app's scope

@IljaN
Copy link
Member Author

IljaN commented Oct 9, 2018

Unless there is a stablished public API in core to handle versions, I'd rather not to use anything
depending on the implementation...

You are correct, by pushing files in to files_version directory we are also already using an implementation detail which happens to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants