Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary encoding setting for HSM #3704

Closed
jnweiger opened this issue Jun 17, 2021 · 3 comments
Closed

Use binary encoding setting for HSM #3704

jnweiger opened this issue Jun 17, 2021 · 3 comments
Assignees

Comments

@jnweiger
Copy link
Contributor

WHAT Needs to be Documented?

WHERE Does This Need To Be Documented (Link)?

WHY Should This Change Be Made?

owncloud/encryption#261 is merged, and has a comment
"When merged, docs relevant. Pls file a docs issue."

@jnweiger
Copy link
Contributor Author

Confirmed in encryption 1.5.1-rc1: HSM works fine with both legacy base64 encoding and new binary encoding.

@mmattel
Copy link
Contributor

mmattel commented Jun 21, 2021

To make it clear, with the upcoming release 1.5.1 of the encryption app, the HSM module correctly works and uses base64 and the new binary encoding (chosen based on the config setting).

This should be noted in https://doc.owncloud.com/server/admin_manual/configuration/server/security/hsmdaemon/

and added via #3710 (hsmdaemon install consistency and accuracy)

@mmattel
Copy link
Contributor

mmattel commented Jun 24, 2021

Closed via #3710

@mmattel mmattel closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants