Failing test scenarios week of 7 March 2022

[phil-davis]

Example from this morning's CI:
https://drone.owncloud.com/owncloud/encryption/2343/21/11

runsh: Total unexpected failed scenarios throughout the test run:
apiEncryption/encoding.feature:38
apiEncryption/encoding.feature:45
apiEncryption/encoding.feature:82
apiEncryption/encoding.feature:93

Example test output:

    Then the content of file "/textfile1.txt" for user "Brian" should be "some data"                                          # FeatureContext::contentOfFileForUserShouldBe()
      The downloaded content was expected to be 'some data', but actually is '<?xml ver'. HTTP status was 500

Log:

{"reqId":"V4x50QOGOQAi6BAlDcjA","level":4,"time":"2022-03-10T00:57:36+00:00","remoteAddr":"192.168.5.4","user":"Brian","app":"webdav","method":"GET","url":"\/remote.php\/webdav\/textfile1.txt",
"message":"Exception: Can not decrypt this file, probably this is a shared file. Please ask the file owner to reshare the file with you.: {\"Exception\":\"OC\\\\Encryption\\\\Exceptions\\\\DecryptionFailedException\",\"Message\":\"Can not decrypt this file, probably this is a shared file. Please ask the file owner to reshare the file with you.\",\"Code\":0,\"Trace\":\"
#0 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/private\\\/Files\\\/Stream\\\/Encryption.php(478): OCA\\\\Encryption\\\\Crypto\\\\Encryption->decrypt(*** sensitive parameters replaced ***)\\n
#1 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/private\\\/Files\\\/Stream\\\/Encryption.php(294): OC\\\\Files\\\\Stream\\\\Encryption->readCache()\\n
#2 [internal function]: OC\\\\Files\\\\Stream\\\\Encryption->stream_read()\\n
#3 \\\/var\\\/www\\\/owncloud\\\/server\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/streams\\\/src\\\/Wrapper.php(55): fread()\\n
#4 \\\/var\\\/www\\\/owncloud\\\/server\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/streams\\\/src\\\/CallbackWrapper.php(96): Icewind\\\\Streams\\\\Wrapper->stream_read()\\n
#5 [internal function]: Icewind\\\\Streams\\\\CallbackWrapper->stream_read()\\n
#6 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/composer\\\/sabre\\\/http\\\/lib\\\/Sapi.php(112): stream_copy_to_stream()\\n
#7 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(490): Sabre\\\\HTTP\\\\Sapi::sendResponse()\\n
#8 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(253): Sabre\\\\DAV\\\\Server->invokeMethod()\\n
#9 \\\/var\\\/www\\\/owncloud\\\/server\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(321): Sabre\\\\DAV\\\\Server->start()\\n
#10 \\\/var\\\/www\\\/owncloud\\\/server\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(67): Sabre\\\\DAV\\\\Server->exec()\\n
#11 \\\/var\\\/www\\\/owncloud\\\/server\\\/remote.php(165): require_once('\\\/var\\\/www\\\/ownclo...')\\n
#12 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/server\\\/apps\\\/encryption\\\/lib\\\/Crypto\\\/Encryption.php\",\"Line\":374}"}

Happens with user-key encryption.

Also https://drone.owncloud.com/owncloud/encryption/2343/25/15 has webUI scenarios failing:

runsh: Total unexpected failed scenarios throughout the test run:
webUIUserKeysType/userKeys.feature:60
webUIUserKeysType/userKeys.feature:61

[phil-davis]

@jvillafanez looks similar to https://github.com/owncloud/ransomware_protection/issues/287 - maybe the same cause?

[phil-davis]

https://drone.owncloud.com/owncloud/encryption/2362/20/11

runsh: Total unexpected failed scenarios throughout the test run:
apiEncryption/encoding.feature:38
apiEncryption/encoding.feature:45
apiEncryption/encoding.feature:82
apiEncryption/encoding.feature:93

Still getting 500 HTTP status

And https://drone.owncloud.com/owncloud/encryption/2362/24/15

runsh: Total unexpected failed scenarios throughout the test run:
webUIUserKeysType/userKeys.feature:60
webUIUserKeysType/userKeys.feature:61

fails same as before.

@jvillafanez or anyone has an idea?

[jvillafanez]

As far as I know, all the failing tests are from the user-key encryption, aren't they?

I've checked that there are keys missing. I think that, if user1 shares a file with user2, a share key from user2 should be placed within user1's scope. So there should be a user2.shareKey file where user1 is storing the keys for the file he's sharing. That key file is currently missing.

This is likely a bug in the code but I still need to track where the actual problem is.

[phil-davis]

As far as I know, all the failing tests are from the user-key encryption, aren't they?

yes - master-key encryption is passing. It is user-key encryption that has problems. In PR #331 I have run full core acceptance tests with user-key encryption. Lots of test scenarios fail, but I think that the common thing is when files are moved
in/out between a received share and the share receiver's own storage.

Something in the core changes of the last few weeks has caused this regression.

[jvillafanez]

owncloud/core#39908 should fix https://drone.owncloud.com/owncloud/encryption/2362/20/11
I'm not sure about the other one. I haven't reproduced the issue with the patch, but maybe I used the wrong steps.

[phil-davis]

I merged owncloud/core#39908 to core, so that will get in the daily-master-qa tarball and nightly encryption tests will run with it. I will also re-run #331

Edit: #331 passed expect for failures that seem to be related to issue #326 - so that looks good for now.

[phil-davis]

nightly encryption CI passed this morning: https://drone.owncloud.com/owncloud/encryption/2365

so previous regressions ahve been fixed, without introducing and other failures - great stuff. Closing this issue.