Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent closing browser tab while saving #179

Open
PVince81 opened this issue Jun 1, 2016 · 3 comments
Open

Prevent closing browser tab while saving #179

PVince81 opened this issue Jun 1, 2016 · 3 comments
Labels

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jun 1, 2016

  1. Open text editor
  2. Type in some text
  3. Hit save
  4. While saving, close the browser window

Expected: a popup appears (beforeunload style)
Actual: browser gets closed, sometimes file not saved

@PVince81 PVince81 added the bug label Jun 1, 2016
@phil-davis
Copy link
Contributor

@PVince81 I do not see any "save" button - was there one in the past?
It seems to now just auto-save "all the time". If I make edits and do not like them, there is no chance to cancel - "the system" seems to have already saved my mistakes.

Somewhat related, I raised #205 - the close button can be pressed too quickly and recent edits are lost.

@PVince81
Copy link
Contributor Author

@phil-davis the save button existed in ancient times and has been designed away, you might find it with a bit of git or github archeology.

cc @tomneedham

@phil-davis
Copy link
Contributor

So this can be closed?
Because if there is no save button, then it can't be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants