"Google Android License.txt" is missing

[voroyam]

Steps to reproduce:

1. get oC 10.8
2. install files_texteditor or Texteditor via Market App
3. run occ integrity:check-app files_texteditor

Expected:
no issues

Result:

- FILE_MISSING:
    - css/DroidSansMono/Google Android License.txt:
      - expected: 110122b00be6594d140457f2d9562cb6a48cdab0587db374a5e60c5527bce807662440082f662a1a97666bcecc1c22530e9edd908637bb5f69776c0573f0c804
      - current:

probable cause - file name has spaces, file is not included in the app package on install.

@jnweiger

I tried getting the file directly from GH but the hash is still different so the integrity check error persists.

[jnweiger]

In files_texteditor 2.4.1 this file is present:

sha256sum /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/*      
b6e6aff5c9e713fb27eb04879880655137513ae4b4c55b0f7d47bf6c0b54aa82  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/DroidSansMono-webfont.eot
a820cd20805fa9a18ce9ed6909419438cdbec4aa367477cb9d797ddfbc97e0f5  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/DroidSansMono-webfont.svg
fb4f123eb1c2ef67818dd1a0230e855b2f9592ecaa29b48cbafd52484eb655ce  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/DroidSansMono-webfont.ttf
412c3bf736afd7d623b2411331434f4f645adcb40c6dfd0a60ce58b642f356a4  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/DroidSansMono-webfont.woff
63da2237f0898b2156ff8b3913e61805b02bf4b0449457db40f757624ef58ece  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/Google Android License.txt
5d34237bef6671bbbf7b308a5d8c634ede5fddda2b68938a8743db0bcb22de3e  /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/stylesheet.css

Also present in files_texteditor-2.3.1

[voroyam]

root@oc:~# ls -la /var/www/owncloud/apps-external/files_texteditor/css/DroidSansMono/
total 356
drwxr-xr-x 2 www-data www-data   4096 Nov  2 13:53 .
drwxr-xr-x 3 www-data www-data   4096 Nov  2 13:53 ..
-rw-r--r-- 1 www-data www-data  78034 Nov  2 13:53 DroidSansMono-webfont.eot
-rw-r--r-- 1 www-data www-data 139678 Nov  2 13:53 DroidSansMono-webfont.svg
-rw-r--r-- 1 www-data www-data  77800 Nov  2 13:53 DroidSansMono-webfont.ttf
-rw-r--r-- 1 www-data www-data  46192 Nov  2 13:53 DroidSansMono-webfont.woff
-rw-r--r-- 1 www-data www-data    421 Nov  2 13:53 stylesheet.css

[voroyam]

occ app:check-code files_texteditor
Analysing /var/www/owncloud/apps-external/files_texteditor/controller/filehandlingcontroller.php
 1 errors
    line  132: == - is discouraged
App is not compliant

[jnweiger]

App is not compliant

That is unforunately "normal". Many apps fail app:check-code -- I have stopped reporting these. Requires product owners attention.

[jnweiger]

wget https://github.com/owncloud/files_texteditor/releases/download/v2.4.1/files_texteditor-2.4.1.tar.gz
tar tvf files_texteditor-2.4.1.tar.gz | grep License.txt
-rw-r--r-- root/root       688 2021-10-12 14:08 files_texteditor/css/DroidSansMono/Google Android License.txt

Identical download from

Do we somehow skip files with 'whitespace in them' during the file during install via WEB UI or something?

My install procedure is

install_app() { ( test -f "$1" && cat "$1" || curl -L -s "$1" ) | su www-data -s /bin/sh -c 'tar zxvf - -C /var/www/owncloud/apps-external'; }

[jnweiger]

Upgrade from 2.3.1 (as shipped with 10.8 to 2.4.1 via web ui also works fine for me:

[voroyam]

manual installation worked for me, download latest release, unpack, move to apps-external, change perms, enable app.

market installation did not work, neither via webUI nor the occ command.