guest versions not saved when files_versions not whitelisted

[phil-davis]

1. set the guests whitelist so that files_versions is not in the whitelist
2. put files_texteditor in the whitelist and enable it (for ease of testing)
3. user Alice creates folder versions-test and shares it with edit access with a new guest [email protected]
4. user Alice creates file versions-test/file.txt
5. user Alice edits file versions-test/file.txt a few times
6. user Alice can see the versions on the classic webUI - good
7. Guest [email protected] logs in and browses into folder versions-test
8. The guest edits file.txt
9. user Alice views the versions of file.txt

Only the old versions caused by Alice are available.

a) The previously current content that Alice entered has been overwritten by the guest user, but is not available as an old version. Alice has "lost" that content.

b) If the guest made multiple edits, then there is no version history of that available to Alice

(a) seems to be "not a good thing" - Alice loses data, and may quite reasonably expect that her data will be available in the version history.

(b) is more debatable - what is the requirement if files_versions is not whitelisted for guests?

[phil-davis]

I think that the whitelist feature is intended to be used so that guests do not see some functionality. In this case (files_versions) the guest user should not see the version history panel on the classic webUI, and should not be able to use the API to query or restore versions.

But I think that as the guest edits the file, the version history should still be saved by the server - so that Alice (a real user) can have that version history available to her.

@pmaier1 what is the requirement?