[FR] Option to always allow subadmins to impersonate their group members

[tomneedham]

No description provided.

[tomneedham]

@pmaier1

[pmaier1]

Currently you need to specify the groups a group admin can impersonate. Do they even match with the groups the user is admin of? Doesn't give the impression. But the group admin will anyway only see the users from the groups he is admin of.

I think it would be way more useful when group admins could just impersonate the users in the groups they are admin of. Why do I need to specify the groups at all? The only use case I can think of would be that I generally want group admins to be able to impersonate their user but I have some group admins that shouldn't be able to. I think this doesn't weigh out the issue that when groups change I always need to take care of changing the specified groups.

@PVince81 can we schedule the change?

[PVince81]

@sharidas can you estimate ?

[sharidas]

A rough estimate would be 0.5 md - 0.7 md. @PVince81

[sharidas]

Let me know if this proposal looks ok

• Here is a screenshot
  

Basically the idea I got is to have 2 options

• To allow all sub admins to impersonate its group members.
• To selectively allow sub admins to impersonate group member.
• At one point of time, either one option could be availed.

[sharidas]

Based on the above proposal #132 (comment) the PR is here #134

[tomneedham]

Rather than disabling the other checkbox, it would be better to use a <input type="radio"> which allows only one toggle. This gives a better UX - otherwise with the proposal above, it is not clear to the user how to get the other checkbox to become enabled again.

[sharidas]

Rather than disabling the other checkbox, it would be better to use a <input type="radio"> which allows only one toggle. This gives a better UX - otherwise with the proposal above, it is not clear to the user how to get the other checkbox to become enabled again.

Indeed radio button. You are right, it improves the UX. I will implement it with the radio button in the current PR. Thanks.

[sharidas]

Updated the UI with radio buttons in the PR #134
One option which I thought would be useful:

• When user selects the radio button to grant all group admins impersonate their user, the drop down list in the second radio button is emptied. Meaning when admin changes the mind and selects the radio button to grant limited group admins access, the group selector is empty. And admin has to start selecting one by one.

[PVince81]

@tomneedham this was released with impersonate 0.5.0 now, you may want to notify the customer