Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Transitive impersonation fails #216

Open
jnweiger opened this issue Sep 19, 2022 · 1 comment
Open

[QA] Transitive impersonation fails #216

jnweiger opened this issue Sep 19, 2022 · 1 comment

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Sep 19, 2022

Seen while testing impersonate-0.5.2-rc.2 on core 10.11.0-rc.2

  • enable impersonte app
  • Admin adds user alice to group alice-g and makes user alice group admin of alice-g
  • Admin adds user bob to group alice-g
  • Admin enters settings -> user authentication and switches to
    (*) Allow group admins of specific groups to impersonate the users within those groups
    with a group list of [alice-g]
  • Admin impersonates alice
  • Now as alice, we try to imersonate bob. This fails. BAD

  • When logged in as a fresh browser session as alice,
  • Alice impersonates bob, and this succeeds.

Expected behaviour:

  • As user alice one should be able to test the permissions setup, even if this is about testing further impersonations.
    I'd consider this a use case for impersonate. Or is that intentionally blocked?
@jnweiger jnweiger mentioned this issue Sep 19, 2022
42 tasks
@phil-davis
Copy link
Contributor

PR #63 prevents this since 2017. Sadly that PR has words like "please don't merge this until I test the problem is fixed" but there is no link to an issue. So we do not know why this transitive impersonation was prevented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants