Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impersonation icon missing after upgrade from 0.0.5 to 0.1.0 (6e55300) #32

Open
agross opened this issue May 10, 2017 · 9 comments
Open

Comments

@agross
Copy link

agross commented May 10, 2017

Hi,

I've just upgraded the app from 9af19c4 to 6e55300. Now the impersonation icon is missing in the user list. The HTTP request to https://example.com/apps/impersonate/getimpersonatedata succeeds with HTTP/200.

With the previous version I enabled the app only for a specific group (admin). Is this sill required?

The new settings page shows "Allow subadmins to impersonate users from these groups". What is a subadmin? I have several users in the "admin" group and the regular/default admin account has been deleted.

I find the new setting a bit confusing:

[x] Allow subadmins to impersonate users from these groups
[ admin foo                                     ]
These groups will be able to impersonate.

Specifically, I'm referring to

These groups will be able to impersonate.

  • Does that mean that users of the admin group are able to impersonate other admin users and foo users?
  • Does that mean foo users are also able the impersonate anyone from admins and foos?

What I would like to achieve is that admin users are able to impersonate anyone in any group.

@sharidas
Copy link
Contributor

This work is under progress. Yes admin user does have privilege to impersonate anyone.

@agross
Copy link
Author

agross commented May 11, 2017

Yes admin user does have privilege to impersonate anyone.

Do you mean the default admin user or users in the admin group?

@sharidas
Copy link
Contributor

The default admin user falls under the admin group.So any user under the admin group will have the privilege to impersonate any user.

@agross
Copy link
Author

agross commented May 11, 2017

OK, thanks for the clarification!

The list of users on the Settings page would then be additional groups that have permission to impersonate anyone. Correct?

@sharidas
Copy link
Contributor

They are the list of groups under which the users fall, which can be impersonated.

@agross
Copy link
Author

agross commented May 11, 2017

Still confused. If

any user under the admin group will have the privilege to impersonate any user

how does the list of groups on the settings page influence "the privilege to impersonate any user"?

If users in the admin group can impersonate anyone, why do I need that list? Is it required to reduce the groups admins can impersonate to just a subset of all groups?

@sharidas
Copy link
Contributor

This list is with respect to group admins and its users.

@agross
Copy link
Author

agross commented May 11, 2017

So the term "subadmins" on the settings page is actually supposed to be "group admins"?

Which means that the group admins for groups listed on the settings page are allowed to impersonate as well? If so, can they also impersonate anyone or just the users of the groups they are admin for or all users of all groups listed on the settings page?

@felixboehm felixboehm added this to the planned milestone Oct 5, 2017
@sharidas
Copy link
Contributor

sharidas commented Dec 6, 2017

Lets say we have user1, user2 and user3 who belong to group group1.
And user1 is the group admin of group1, then user1 can impersonate user2 and user3 only.

@sharidas sharidas modified the milestones: QA, triage Dec 6, 2017
@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants