Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX review minor/major #416

Open
PVince81 opened this issue Nov 16, 2018 · 12 comments
Open

UX review minor/major #416

PVince81 opened this issue Nov 16, 2018 · 12 comments
Assignees
Milestone

Comments

@PVince81
Copy link
Contributor

Following #391 there were some UI changes.

Would be good to get a UX and design review for the changes to see if they fit.

cc @pmaier1 fyi

@PVince81 PVince81 added this to the backlog milestone Nov 16, 2018
@PVince81
Copy link
Contributor Author

some screenshots here: #387 (comment)

@PVince81
Copy link
Contributor Author

@davitol
Copy link

davitol commented Nov 23, 2018

Running upgrade command with --major option when there's no major option available, should the command install the minor version or refuse the upgrade?

screen shot 2018-11-23 at 14 49 46

@PVince81
Copy link
Contributor Author

As an admin, I'd say whenever I specify --major mostly means I want to "update all the things to the latest whatever". When I don't specify it, it means "safe update to the latest minor".

So if there is no major and --major is specified, I'd say also update to the latest minor if no major exists.

@VicDeo @pmaier1 @DeepDiver1975 thoughts ?

@VicDeo
Copy link
Member

VicDeo commented Nov 23, 2018

As for me: we have a limit until --major is specified. --major option removes this limit.
So it is expected.
As I already wrote I don't like the idea of splitting to minor/major at all...

@felixheidecke
Copy link
Contributor

I'd recommend using the same UI for updating in the details view as well as on the update page.
See: #391 (comment)

Namely having the action be the name of the button (update to 1.0.0) along with the drop-down.
Also color diff while hovering over the button with the caret, ist nice. Should be consistent across the whole button.

I can take care of that if you like.

@PVince81
Copy link
Contributor Author

@felixheidecke please take care. if the current UI isn't too bad let's keep the UX improvements for the new market app release (0.3.1).

@PVince81 PVince81 modified the milestones: backlog, development, QA Nov 29, 2018
@PVince81
Copy link
Contributor Author

please PR to release-0.3.0 branch, unless you think the current UI is ok for the release

@PVince81
Copy link
Contributor Author

we should fix the occ command however @VicDeo

@VicDeo
Copy link
Member

VicDeo commented Nov 29, 2018

@PVince81 yep. #424

@PVince81
Copy link
Contributor Author

@felixheidecke I need your feedback here to decide whether to wait longer for UX tweaks or if I should go ahead with RC2 + final

@felixheidecke
Copy link
Contributor

felixheidecke commented Dec 3, 2018

The current UI is "okay" but not nice. We can go ahead and release it. About 2hrs to fix.

@PVince81 PVince81 modified the milestones: QA, backlog Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants