Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CSRF documentation and generation #501

Open
1 task
aronerben opened this issue Jun 18, 2021 · 1 comment
Open
1 task

Improve CSRF documentation and generation #501

aronerben opened this issue Jun 18, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@aronerben
Copy link
Contributor

aronerben commented Jun 18, 2021 •
edited
Loading

  • Mention that the default __Host prefix only works with HTTPS, so testing on HTTP localhost with production won't work
  • Change <input type="hidden" name="csrf" value=.../> to <input type="hidden" name="_csrf" value=.../> here
  • Fix the admin UI CSRF name here to use the CSRF middleware parameter
@aronerben
Copy link
Contributor Author

Update 20.12.2021:
First two TODOs are no longer relevant because the cookie the CSRF is stored in changed (1) and the input name is parameterized now (2).

@aronerben aronerben added the good first issue Good for newcomers label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aronerben