Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP flavor Docker Image v8 family not used the latest available (8.1.0) #4214

Open
llaville opened this issue Nov 2, 2024 · 4 comments
Open
Labels
bug Something isn't working

Comments

@llaville
Copy link
Collaborator

llaville commented Nov 2, 2024

Describe the bug

I've didn't noticed it yet, until today, but the PHP flavor Docker Image used is not the latest v8 family available

To Reproduce

With my project BOX Manifest (but all used the same principle), the GitHub Action Workflow that run MegaLinter is referenced by

jobs:
    lint_files:
        uses: llaville/.github/.github/workflows/mega-linter.yml@master

And parent workflow https://github.com/llaville/.github/blob/master/.github/workflows/mega-linter.yml#L70 that reference the PHP flavor

Expected behavior

Got latest Docker Image 8.1.0 but got only 8.0.0

Screenshots
github com_llaville_box-manifest_actions_runs_11640840825_job_32418655840

Additional context

Images available on Docker Hub

hub docker com_r_oxsecurity_megalinter-php_tags

@llaville llaville added the bug Something isn't working label Nov 2, 2024
@llaville
Copy link
Collaborator Author

llaville commented Nov 2, 2024

BTW, when I click on Megalinter documentation GitHub Action on Usage section of PHP flavor
(see https://megalinter.io/latest/flavors/php/)

I got a 404
from (URL https://megalinter.io/8.1.0/installation/#github-action redirected to https://megalinter.io/latest/installation/#github-action)

@llaville
Copy link
Collaborator Author

llaville commented Nov 2, 2024

When I pull locally (on my dev platform) the latest v8 Docker Image, I don't have the same issue

docker pull oxsecurity/megalinter-php:v8

This is probably the reason why I don't noticed until today that GitHub Action did not pull the v8.1 image

llaville added a commit to llaville/box-manifest that referenced this issue Nov 2, 2024
@llaville
Copy link
Collaborator Author

llaville commented Nov 2, 2024

Ok, found origin !

It seems that GitHub Action syntax does not works like Docker Image syntax :

When we try with :

oxsecurity/megalinter/flavors/php@v8

And

oxsecurity/megalinter/flavors/[email protected]

We did not get the same image (expected to have both 8.1.0), but in first case we still have 8.0.0

While with Docker Image syntax, both syntaxes did the same thing (pull the latest v8.1.0)

oxsecurity/megalinter-php:v8
// or
oxsecurity/megalinter-php:v8.1.0

Confirmed by my test with commit llaville/box-manifest@e0c6e68 and llaville/.github@master...ml_v8

@nvuillam
Copy link
Member

nvuillam commented Nov 3, 2024

@llaville I noticed an issue with a CI job that stopped working after v8.0.0

https://github.com/oxsecurity/megalinter/actions/runs/11650500232/job/32439311091

When we release a minor version, for example 8.1.0, it is supposed to overwrite v8, on the docker image, but also on the github action tag

The action is failing, I declared a bug on their repo -> Actions-R-Us/actions-tagger#94

llaville added a commit to llaville/box-manifest that referenced this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants