translations for this plugin

[xgp]

@xgp could you help me what's the supported way to create custom translations for this plugin in our own instance? I think I should create a messages_hu.properties and translate this file.

But where do I put this messages_hu.properties in the docker container?

Thanks,

Originally posted by @vilmosnagy in #9 (comment)

[xgp]

@vilmosnagy I don't have any experience putting it directly in the container. I've only done it 2 other ways:

1. building a custom distribution of this extension with the messages file in the theme-resources/messages/ directory.
2. in another extension, put it in the theme-resources/messages/ directory, and it should get picked up in the classpath and applied

Regarding 1, I'd take a PR with a hungarian translation, if you'd be willing to share it.

[vilmosnagy]

@xgp

Regarding 1, I'd take a PR with a hungarian translation, if you'd be willing to share it.

Let me do a quick research in our company, but I think we'll open a PR soon 🙂 Thanks for the opportunity.

One question though: as we're using kc25 at this moment, would you be willing to merge this to xgp/25 and release it as a jar (eg.: 0.29.1?) I'd be willing to open 2 PRs if the strings differ in any way.

[xgp]

One question though: as we're using kc25 at this moment, would you be willing to merge this to xgp/25 and release it as a jar (eg.: 0.29.1?) I'd be willing to open 2 PRs if the strings differ in any way.

Yes.

[pnzrr]

Quick addition of translations

@vilmosnagy perhaps you can check the Hungarian one for accuracy?

[vilmosnagy]

LGTM

[xgp]

fixed in #96