Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of e/g CompositeID in 12.5.X #110

Merged
merged 70 commits into from
Apr 4, 2023
Merged

Integration of e/g CompositeID in 12.5.X #110

merged 70 commits into from
Apr 4, 2023

Commits on Jan 27, 2023

  1. starting point composite ID emulator

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c848045 View commit details
    Browse the repository at this point in the history

  2. cast floats to apfixed, run inference and compare output

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    171cc91 View commit details
    Browse the repository at this point in the history

  3. add scheleton to plug in CompositeID

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ef982cf View commit details
    Browse the repository at this point in the history

  4. incorporate compositeID as alternative to tkElectron, using skeleton … 

    …of previous commit
    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    7edb2b7 View commit details
    Browse the repository at this point in the history

  5. fix DR and add some verbosity

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    4e7c57f View commit details
    Browse the repository at this point in the history

  6. equip to write decoded tracks to the event

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    2e89963 View commit details
    Browse the repository at this point in the history

  7. add calo coordinates to PFCandidates

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    55c4544 View commit details
    Browse the repository at this point in the history

  8. trying to move normalizations to different function

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5d19697 View commit details
    Browse the repository at this point in the history

  9. implement two BDT WPs

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    62d8ade View commit details
    Browse the repository at this point in the history

  10. fixes

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3ac8427 View commit details
    Browse the repository at this point in the history

  11. Mapping of scores and WPs for consistent comparisons

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0d4e16d View commit details
    Browse the repository at this point in the history

  12. trivialize the CompositeCandidate interface

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    108deea View commit details
    Browse the repository at this point in the history

  13. remove the cut on the CompositeID BDT and store the score in the TkEl… 

    …ectron object + some cosmetics
    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e89f8fc View commit details
    Browse the repository at this point in the history

  14. Remove pt10 cut from composite candidates

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    98932ee View commit details
    Browse the repository at this point in the history

  15. remove duplicated files

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    525233e View commit details
    Browse the repository at this point in the history

  16. remove duplicated files

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f8e4cea View commit details
    Browse the repository at this point in the history

  17. fix typo

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    42d7ce2 View commit details
    Browse the repository at this point in the history

  18. add missing headers

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    32aa4c7 View commit details
    Browse the repository at this point in the history

  19. first implementation of the new data-formats for CompositeID input fe… 

    …atures
    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    bbc27da View commit details
    Browse the repository at this point in the history

  20. reorder the code for adding the cluster-shape variables used by the c… 

    …omposite ID to the HGC clusters
    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0b28796 View commit details
    Browse the repository at this point in the history

  21. temporary changes to run emulator from firmware testbench

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    cd9bd45 View commit details
    Browse the repository at this point in the history

  22. make # of composite candidates per cluster configurabel

    @cerminar
    CI bot authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0934ff3 View commit details
    Browse the repository at this point in the history

  23. add parameter for # of composite candidates per cluster

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    885ca19 View commit details
    Browse the repository at this point in the history

  24. change to new model with max tree depth of 4

    @cerminar
    Peter Eduard Meiring authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    56ed6f7 View commit details
    Browse the repository at this point in the history

  25. add variales for composite ID to HGCAL raw dataformat

    @cerminar
    CI bot authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    8df4f6a View commit details
    Browse the repository at this point in the history

  26. Replace egamma BDT with model using no input scaling

    @cerminar
    CI bot authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c76cda6 View commit details
    Browse the repository at this point in the history

  27. Update egamma BDT to model trained on hw values. Use inversion fn fro… 

    …m jets
    @cerminar
    CI bot authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    b5ee230 View commit details
    Browse the repository at this point in the history

  28. fix typo

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    47d4350 View commit details
    Browse the repository at this point in the history

  29. switch to rounding for consisntency with HGC raw data format

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5874bb5 View commit details
    Browse the repository at this point in the history

  30. fix assignment of cluster variables

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c5b620f View commit details
    Browse the repository at this point in the history

  31. add chi2 variables from track word, address some rounding issues in t… 

    …he hgcal input
    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1549f9f View commit details
    Browse the repository at this point in the history

  32. mostly cosmetics

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3ed4d4f View commit details
    Browse the repository at this point in the history

  33. move the chi2 back to be an emulator only quantity

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    42dbbf2 View commit details
    Browse the repository at this point in the history

  34. fix constexpress

    @cerminar
    CI bot authored and cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0a2e3e9 View commit details
    Browse the repository at this point in the history

  35. code-format and remove unused parameters from CombinedID configuration

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    a45417a View commit details
    Browse the repository at this point in the history

  36. back to 1000 events

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    9b6c9f9 View commit details
    Browse the repository at this point in the history

  37. code-format

    @cerminar
    cerminar committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3096e6a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Drop includes not needed any more

    @cerminar
    cerminar committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c9102cd View commit details
    Browse the repository at this point in the history

  2. Event version is back to 12

    @cerminar
    cerminar committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4eba6d6 View commit details
    Browse the repository at this point in the history

  3. Introduce typedef for bdt features type + some std here and there

    @cerminar
    cerminar committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    a72fe0c View commit details
    Browse the repository at this point in the history

  4. code format

    @cerminar
    cerminar committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    fad8b55 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. undo changes to HGC ntuplizer

    @cerminar
    cerminar committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    dc0c262 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. add slim version of packed Tk and Calo objs

    @cerminar
    cerminar committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ccbf885 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. protect conversion for empy (0) words

    @cerminar
    cerminar committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    aea1f6a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Avoid code duplication or SLIM objects and other cosmetics

    @cerminar
    cerminar committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    466463b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. make unpacking of the addtional track variables configurable for barr… 

    …el and endcap
    @cerminar
    cerminar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ac2694c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Reinstate conifer runtime exception. Use cms::Exception in CMSSW cont… 

    …ext, std::runtime_error outside
    @thesps
    thesps committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d6a0d7e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge pull request #13 from thesps/composite_eleid_125X_v0+cnf-fix 

    Conifer exceptions for composite ID
    @cerminar
    cerminar authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    b84d29b View commit details
    Browse the repository at this point in the history

  2. code format

    @cerminar
    cerminar committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    c7b819c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Handle BDT WPs and do some cosmetics

    @cerminar
    cerminar committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e75fcf2 View commit details
    Browse the repository at this point in the history

  2. code format and fix python

    @cerminar
    cerminar committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ac9470b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. cosmetics

    @cerminar
    cerminar committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    c5e1296 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. new model with srrtot rescaled, binned chi2 variables and without z0

    Peter Eduard Meiring committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8dfef6d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #14 from Pmeiring/composite_eleid_125X_v0_newmodel 

    New model with srrtot rescaled, binned chi2 variables and without z0
    @cerminar
    cerminar authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c2ba610 View commit details
    Browse the repository at this point in the history

  3. fix srr conversion back to float

    @cerminar
    cerminar committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7cb2bd4 View commit details
    Browse the repository at this point in the history

  4. Fix constexpr

    @cerminar
    cerminar committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    b9e3ae9 View commit details
    Browse the repository at this point in the history

  5. code-format

    @cerminar
    cerminar committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    feb0b83 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Set working points. Don't transform WPs or BDT score

    @thesps
    thesps committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4f0231c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #15 from thesps/composite_eleid_125X_v0_wps 

    Set working points. Don't transform WPs or BDT score
    @cerminar
    cerminar authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    64e9f43 View commit details
    Browse the repository at this point in the history

  3. attempt to rounding problems in scaling srrtot

    @cerminar
    cerminar committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fb34575 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. workaround to propagate BDT score to Layer2 objects

    @cerminar
    cerminar committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b3dde57 View commit details
    Browse the repository at this point in the history

  2. remove uneeded header

    @cerminar
    cerminar committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f64aac1 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. make names of score variables more future proof

    @cerminar
    cerminar committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    53081b5 View commit details
    Browse the repository at this point in the history

  2. obsolete comment

    @cerminar
    cerminar committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    ce0ce6e View commit details
    Browse the repository at this point in the history

  3. Fix type used in 1/pT

    @thesps
    thesps committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    73b2049 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #16 from thesps/composite_eleid_125X_v0_wps 

    Fix type used in 1/pT
    @cerminar
    cerminar authored Mar 31, 2023
    Configuration menu
    Copy the full SHA
    8eaa9df View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. update the model: now built for using the HW input values

    @cerminar
    cerminar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    030489a View commit details
    Browse the repository at this point in the history

  2. update tight WP

    @cerminar
    cerminar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    846567b View commit details
    Browse the repository at this point in the history

  3. Update tight WP for 90%eff

    @cerminar
    cerminar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8d77d91 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Duplicate HGCAl TkeElectrons to run legacy Elliptic Algorithms for Ph… 

    …ysics Validation purposes
    @cerminar
    cerminar committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f2aa770 View commit details
    Browse the repository at this point in the history