Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Integration branch for HGCal multiboard test [DO NOT MERGE] #119

Open
wants to merge 53 commits into
base: L1PF_12_5_X
Choose a base branch
from
Open

Draft: Integration branch for HGCal multiboard test [DO NOT MERGE] #119

wants to merge 53 commits into from

Conversation

gpetruc
Copy link
Collaborator

@gpetruc gpetruc commented Jun 15, 2023

Pushing here a branch with the changes to be used for developing and running the HGCal → Correlator Layer 1 Endcap multiboard test.
It includes the branch from @EmyrClement with the standalone HGCal emulator and patches for the Correlator Layer 1 emulator:

  • encoding of the hgcal raw cluster word with the new format defined by HGCal, taken from the standalone emulator, including debug comparison of difference wrt what we would encode reading from the floating point variables of the cluster
  • updated emulator for the HGCal cluster decoder that reads the new format and rescales, computes on the fly or makes up some variables we're using in the ID so that objects will be accepted by the algorithms (though of course not with the best physics performance)
  • debug comparison of the output of encoding + decoding vs floating point values in the cluster object
  • switching off the extra calibrations and BDT IDs for the clusters
  • change the encoding of some cluster shape variables saved in the Correlator objects to make the encoding and decoding more friendly

Of course this is only for testing, not for future merging.

@cerminar

tswilliams and others added 30 commits April 13, 2023 19:07
@tswilliams
L1T demonstrator tools: Add support for new EMP file format
ed47ca6
@tswilliams
Fix 'valid missing' bug in new EMP write function
baefec5
@tswilliams
Demonstrator tools: Add ability to set board ID
fbc0750
@tswilliams
Formatting update
60ece04
@folguera
Merged l1t-phase2-v57 from repository cms-l1t-offline with cms-merge-…
539c52b 
…topic
@folguera
Low-pt muon fix
fc72a1d
@EmyrClement
Stage 2 clustering emulator
674f689 
Co-authored-by: Jonathon Langford <[email protected]>
@EmyrClement
Changes for interface test (squashed)
1e1d7df 
Changes for interface test (squashed)

Start adding cluster sum wrods.

L1T demonstrator tools: Add support for new EMP file format

Port pattern file writer for S2 output.

Set pattern file format to CSP-style

Fix 'valid missing' bug in new EMP write function

Add hw definition of cluster sum words, produce pattern files for cluster sum recrod.

Demonstrator tools: Add ability to set board ID

Populate first two words of output clusters.

Bug fix, carried over from another branch.

Fully populate cluster sum and output cluster words.

Update pattern file writter.

Add pattern file reader

Remove check on expected valid frames.  Required for variable length packets.

Add config for pattern file reader.  Commentn out some debug text.

Remove large products from output.

Update eta to interface doc definition.

Synch pt digitisation with firmware

Explore changes to improve perfromance of emulator.

Store layer info in ntuples.

Try varying seed threhold vs r over z

Start aliging to latest firmware iteration.

WIP for rebase.
@folguera
switched to double to accomodate getparameter
d39280c
@folguera
make eta parameter configurable
b6a2d43
@epalencia
Merge pull request cms-sw#1109 from folguera/125Xp1_FlagToRestrictGMT…
59b9d0f 
…outputToSAAtLowpT

Add flag to drop quality of low-pt TkMuons without an SA match
@epalencia
Merge pull request cms-sw#1129 from gpetruc/barrel_sorter_rebased_to_…
d5b6578 
…v1.16

Updated correlator layer 1 e/gamma sorter
@epalencia
Merge pull request cms-sw#1107 from tswilliams/demonstrator-tools-new…
b687ab0 
…-emp-format-1252patch1

Demonstrator tools: Support for EMP v0.7.x buffer file format
@EmyrClement
Remove commented out lines.
bb7bb72
@EmyrClement
Make values in edm object match HW values.
ee8faf0
@gpetruc
Merge remote-tracking branch 'EmyrClement/S2Emu_InterfaceTest_l1t-pha…
dae9610 
…se2-64' into for_HGCal_multiboard_125x_new
@gpetruc
Version for HGC Multiboard test
7b30319
@gpetruc
Configure even main make_l1ct_binaryFiles_cfg for HGC test (for CI)
15a1994
@cerminar
Merged for_HGCal_multiboard_125x from repository gpetruc with cms-mer…
f5937ee 
…ge-topic
@gpetruc
Configure regionizer emulator for fwd hgcal region instead of ideal one
ab90e30
@cerminar
Write ID score to FW object and tune loose WP.
256c33d
@gpetruc
Merge pull request #18 from cerminar/eg_hgc_multiboard_v0
46fcbb2 
Add ID score to the electron firmware object
@gpetruc
Small bugfixes to unpacker and eg emulator
439de2b
@EmyrClement
Fix emu-fw disagreement for sigma_roz
6a45f5a
@EmyrClement
Fix emu-fw disagreement for eta
31086e0
@gpetruc
Merge tag 'l1t-phase2-v67' into multiboard_correlator
9f487f1 
Demonstrator tools: Support for EMP v0.7.x buffer file format
@gpetruc
Configure regionizer emulator for fwd hgcal region instead of ideal one
6edaed2
@gpetruc
DemonstratorTools: support transparent compression of pattern files
10fec7c
@gpetruc
Add check on file extension (txt, txt.gz, txt.xz)
930c839
@gpetruc
Merge remote-tracking branch 'my-cmssw/DemonstratorTools_compression_…
a54edda 
…l1t' into multiboard_correlator
@gpetruc gpetruc mentioned this pull request Jul 4, 2023
Merged
gpetruc and others added 19 commits July 5, 2023 22:08
@gpetruc
make_l1ct_binaryFiles_cfg.py: option to use serenity settings for barrel
2754962
@EmyrClement
Workaround for different LSB assumed in clustering and CP blocks.
4a416c0
@EmyrClement
Improve emulation of sigma r/z r/z
aed96ba
@EmyrClement
Remove one hard coded number.
6078452
@EmyrClement
Update pattern file writer/reader.
3bccc17
@EmyrClement
Synchronise pattern file naming with CTL1.
6cf1c33
@gpetruc
Merge remote-tracking branch 'EmyrClement/S2Emu_InterfaceTest_l1t-pha…
e928ee6 
…se2-64' into for_HGCal_multiboard_125x
@gpetruc
Merge remote-tracking branch 'my-cmssw/multiboard_correlator' into fo…
42b7197 
…r_HGCal_multiboard_125x
@gpetruc
Update L1THGCalUtilities Stage2FileWriter for updated DemonstratorTools
1f03468
@gpetruc
Update make_l1ct_binaryFiles_HGCTest_cfg.py
4317ca6
@gpetruc
Checkpoint: fix phi andd sector assignment
0792e2c
@gpetruc
Further improvements to unpacker to try improve agreement
24fbf21
@EmyrClement
Fix emulation of EMF, add emulation of firmware bug for sigma_rzrz.
ac62758
@EmyrClement
Another fix for sigma_rzrz emulation.
bc18748
@EmyrClement
Remove printout
01bbc3b
@gpetruc
fix ordering of puppi candidates in foward region
7721c5a
@gpetruc
Emulate firmware bug in brem recovery (same brem can be attached to m…
53269ab 
…ultiple clusters)
@gpetruc
Merge remote-tracking branch 'EmyrClement/S2Emu_InterfaceTest_l1t-pha…
9accec0 
…se2-64' into for_HGCal_multiboard_125x
@gpetruc
Code-format
beaaf3f
@cerminar cerminar mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gpetruc @tswilliams @folguera @EmyrClement @epalencia @cerminar